Commit d305bf6e authored by Manu Cornet's avatar Manu Cornet Committed by Commit Bot

CrOS Shelf: Minor TODO cleanup

Change-Id: I1e561547fe954e8516ed0daf80ccd8dcf33517c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750347
Auto-Submit: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686415}
parent 55fecc32
......@@ -360,10 +360,6 @@ void ShelfView::Init() {
for (ShelfItems::const_iterator i = items.begin(); i != items.end(); ++i) {
views::View* child = CreateViewForItem(*i);
// TODO(manucornet): Remove this if statement once home and back are not
// allowed shelf item types in the model any longer.
if (!child)
continue;
child->SetPaintToLayer();
view_model_->Add(child, static_cast<int>(i - items.begin()));
AddChildView(child);
......@@ -1985,11 +1981,6 @@ void ShelfView::ShelfItemAdded(int model_index) {
}
const ShelfItem& item(model_->items()[model_index]);
views::View* view = CreateViewForItem(item);
// Some item types are ignored and yield a null view. Ignore those.
// TODO(manucornet): Remove this if statement once home and back are no
// longer acceptable shelf item types in the model.
if (!view)
return;
AddChildView(view);
// Hide the view, it'll be made visible when the animation is done. Using
// opacity 0 here to avoid messing with CalculateIdealBounds which touches
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment