Commit d322eaa1 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

[ios] Use proper type in AppDistributionProvider::InitializeFirebase

Instead of using a int64_t to pass the output of base::Time::ToTimeT,
pass a proper typed base::Time value to InitializeFirebase.

Bug: none
Change-Id: Idfb4dcf3ba9e54daaf882f5bbcad9bda61e4e739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246582
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#778382}
parent b4ce76bd
......@@ -813,9 +813,10 @@ void MainControllerAuthenticationServiceDelegate::ClearBrowsingData(
->ScheduleDistributionNotifications(URLLoaderFactory,
is_first_run);
const int64_t install_date =
const base::Time install_date = base::Time::FromTimeT(
GetApplicationContext()->GetLocalState()->GetInt64(
metrics::prefs::kInstallDate);
metrics::prefs::kInstallDate));
ios::GetChromeBrowserProvider()
->GetAppDistributionProvider()
->InitializeFirebase(install_date, is_first_run);
......
......@@ -7,8 +7,8 @@
#include <string>
#include "base/macros.h"
#include "base/memory/scoped_refptr.h"
#include "base/time/time.h"
namespace network {
class SharedURLLoaderFactory;
......@@ -19,6 +19,9 @@ class AppDistributionProvider {
AppDistributionProvider();
virtual ~AppDistributionProvider();
AppDistributionProvider(const AppDistributionProvider&) = delete;
AppDistributionProvider& operator=(const AppDistributionProvider&) = delete;
// Returns the distribution brand code.
virtual std::string GetDistributionBrandCode();
......@@ -33,10 +36,8 @@ class AppDistributionProvider {
// Initializes Firebase for installation attribution purpose. |install_date|
// is used to detect "legacy" users that installed Chrome before Firebase
// was integrated and thus should not have Firebase enabled.
virtual void InitializeFirebase(base::Time install_date, bool is_first_run);
virtual void InitializeFirebase(int64_t install_date, bool is_first_run);
private:
DISALLOW_COPY_AND_ASSIGN(AppDistributionProvider);
};
#endif // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_DISTRIBUTION_APP_DISTRIBUTION_PROVIDER_H_
......@@ -22,5 +22,13 @@ void AppDistributionProvider::ScheduleDistributionNotifications(
void AppDistributionProvider::CancelDistributionNotifications() {}
void AppDistributionProvider::InitializeFirebase(base::Time install_date,
bool is_first_run) {
// Call int64_t version since it is the only one implemented downstream.
// Will remove this once downstream has been fixed to overload the
// base::Time version of the function.
InitializeFirebase(install_date.ToTimeT(), is_first_run);
}
void AppDistributionProvider::InitializeFirebase(int64_t install_date,
bool is_first_run) {}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment