[FCM] Store laziness information in a separate SharedPreferences

Lazy sunbscription information were stored in the default
SharedPreferences file.
However, the plan now is to store the queued FCM messages in
SharedPrefernces as well. Therefore, it makes sense to use their own
SharedPrefences file for that.

Bug: 882887
Change-Id: Id78642f5c849c1458db04fdae8b85ceaf328fff6
Reviewed-on: https://chromium-review.googlesource.com/c/1264206Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599233}

components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java

@@ -4,6 +4,7 @@
 
 package org.chromium.components.gcm_driver.instance_id;
 
+import android.content.Context;
 import android.content.SharedPreferences;
 import android.os.Bundle;
 
@@ -26,6 +27,7 @@ import java.util.concurrent.ExecutionException;
 @JNINamespace("instance_id")
 public class InstanceIDBridge {
     private static final String FCM_LAZY_SUBSCRIPTIONS = "fcm_lazy_subscriptions";
+    private static final String PREF_PACKAGE = "org.chromium.components.gcm_driver.instance_id";
     private final String mSubtype;
     private long mNativeInstanceIDAndroid;
     /**
@@ -47,7 +49,9 @@ public class InstanceIDBridge {
     @VisibleForTesting
     public void storeLazinessInformation(final String authorizedEntity, boolean isLazy) {
         if (isLazy) {
-            SharedPreferences sharedPrefs = ContextUtils.getAppSharedPreferences();
+            Context context = ContextUtils.getApplicationContext();
+            SharedPreferences sharedPrefs =
+                    context.getSharedPreferences(PREF_PACKAGE, Context.MODE_PRIVATE);
             Set<String> lazyIds = new HashSet<>(
                     sharedPrefs.getStringSet(FCM_LAZY_SUBSCRIPTIONS, Collections.emptySet()));
             lazyIds.add(buildSubscriptionUniqueId(mSubtype, authorizedEntity));
@@ -62,7 +66,9 @@ public class InstanceIDBridge {
      * Returns whether the subscription with the |appId| and |senderId| is lazy.
      */
     public static boolean isSubscriptionLazy(final String appId, final String senderId) {
-        SharedPreferences sharedPrefs = ContextUtils.getAppSharedPreferences();
+        Context context = ContextUtils.getApplicationContext();
+        SharedPreferences sharedPrefs =
+                context.getSharedPreferences(PREF_PACKAGE, Context.MODE_PRIVATE);
         Set<String> lazyIds = new HashSet<>(
                 sharedPrefs.getStringSet(FCM_LAZY_SUBSCRIPTIONS, Collections.emptySet()));
         return lazyIds.contains(buildSubscriptionUniqueId(appId, senderId));