Commit d3aee5eb authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

Replace some TODO(treib)s with crbug references

TBRing these comment-only changes.
TBR=treib

Bug: none
Change-Id: I457ec0eda2c472c6f001329a1d9752fcba5673d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547704
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646390}
parent 022538b0
......@@ -219,8 +219,8 @@ ExtensionDisabledGlobalError::GetBubbleViewMessages() {
messages.push_back(
l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WILL_HAVE_ACCESS_TO));
} else {
// TODO(treib): If NeedCustodianApprovalForPermissionIncrease, add an extra
// message for supervised users. crbug.com/461261
// TODO(crbug.com/461261): If NeedCustodianApprovalForPermissionIncrease,
// add an extra message for supervised users.
messages.push_back(
l10n_util::GetStringUTF16(IDS_EXTENSION_DISABLED_ERROR_LABEL));
}
......@@ -233,8 +233,8 @@ ExtensionDisabledGlobalError::GetBubbleViewMessages() {
base::string16 ExtensionDisabledGlobalError::GetBubbleViewAcceptButtonLabel() {
if (util::IsExtensionSupervised(extension_, service_->profile())) {
// TODO(treib): Probably use a new string here once we get UX design.
// For now, just use "OK". crbug.com/461261
// TODO(crbug.com/461261): Probably use a new string here once we get UX
// design. For now, just use "OK".
return l10n_util::GetStringUTF16(IDS_OK);
}
if (is_remote_install_) {
......
......@@ -672,7 +672,7 @@ TEST(PermissionsTest, IsPrivilegeIncrease) {
{"hosts6", false}, // http://a.com -> http://a.com + http://a.co.uk
{"permissions1", false}, // tabs -> tabs
{"permissions2", true}, // tabs -> tabs,bookmarks
// TODO(treib): This is wrong, kAllHosts implies kTabs. crbug.com/512344
// TODO(crbug.com/512344): This is wrong, kAllHosts implies kTabs.
{"permissions3", true}, // http://*/* -> http://*/*,tabs
{"permissions5", true}, // bookmarks -> bookmarks,history
{"equivalent_warnings", false}, // tabs --> tabs, webNavigation
......
......@@ -331,7 +331,7 @@ std::unique_ptr<base::DictionaryValue> ConstructAboutInformation(
Stat<std::string>* username = section_identity->AddStringStat("Username");
Stat<bool>* user_is_primary = section_identity->AddBoolStat("Is Primary");
Stat<std::string>* auth_error = section_identity->AddStringStat("Auth Error");
// TODO(treib): Add the *time* of the auth error?
// TODO(crbug.com/948074): Add the time of the auth error.
Section* section_credentials = section_list.AddSection("Credentials");
Stat<std::string>* request_token_time =
......
......@@ -526,11 +526,11 @@ void ProfileSyncService::StartUpSlowEngineComponents() {
ReportPreviousSessionMemoryWarningCount();
// TODO(treib): Consider kicking off an access token fetch here. Currently,
// the flow goes as follows: The SyncEngine tries to connect to the server,
// but has no access token, so it ends up calling OnConnectionStatusChange(
// syncer::CONNECTION_AUTH_ERROR) which in turn causes SyncAuthManager to
// request a new access token. That seems needlessly convoluted.
// TODO(crbug.com/948148): Consider kicking off an access token fetch here.
// Currently, the flow goes as follows: The SyncEngine tries to connect to the
// server, but has no access token, so it ends up calling
// OnConnectionStatusChange(syncer::CONNECTION_AUTH_ERROR) which in turn
// causes SyncAuthManager to request a new access token.
}
void ProfileSyncService::Shutdown() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment