Commit d3b3b22e authored by Changwan Ryu's avatar Changwan Ryu Committed by Commit Bot

Fix WPT shell test failure

It is not clear why this only fails on L/M, but
BiMap#remove(Object) is derived from Map#remove(Object) and should
only accept key as parameter.

Bug: 1010552
Change-Id: I00bf337ac1eb88f4868558e8a795f0d131c42657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838158Reviewed-by: default avatarNate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702627}
parent 07143713
...@@ -176,7 +176,7 @@ public class WebPlatformTestsActivity extends Activity { ...@@ -176,7 +176,7 @@ public class WebPlatformTestsActivity extends Activity {
if (parent != null) parent.removeView(childLayout); if (parent != null) parent.removeView(childLayout);
WebView childWebView = mLayoutToWebViewBiMap.get(childLayout); WebView childWebView = mLayoutToWebViewBiMap.get(childLayout);
removeAndDestroyWebView(childWebView); removeAndDestroyWebView(childWebView);
mLayoutToWebViewBiMap.remove(childLayout, childWebView); mLayoutToWebViewBiMap.remove(childLayout);
if (mTestCallback != null) mTestCallback.onChildLayoutRemoved(); if (mTestCallback != null) mTestCallback.onChildLayoutRemoved();
} }
......
...@@ -19,7 +19,6 @@ import org.junit.Test; ...@@ -19,7 +19,6 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.chromium.base.test.BaseJUnit4ClassRunner; import org.chromium.base.test.BaseJUnit4ClassRunner;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.webview_shell.WebPlatformTestsActivity; import org.chromium.webview_shell.WebPlatformTestsActivity;
import java.util.ArrayList; import java.util.ArrayList;
...@@ -73,7 +72,6 @@ public class WebPlatformTestsActivityTest { ...@@ -73,7 +72,6 @@ public class WebPlatformTestsActivityTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/1010552")
public void testOpenCloseWindow() throws Exception { public void testOpenCloseWindow() throws Exception {
final BlockingQueue<Integer> queue = new LinkedBlockingQueue<>(); final BlockingQueue<Integer> queue = new LinkedBlockingQueue<>();
...@@ -99,7 +97,6 @@ public class WebPlatformTestsActivityTest { ...@@ -99,7 +97,6 @@ public class WebPlatformTestsActivityTest {
@Test @Test
@MediumTest @MediumTest
@DisabledTest(message = "crbug.com/1010552")
public void testNestedOpensAndCloses() throws Exception { public void testNestedOpensAndCloses() throws Exception {
final BlockingQueue<Integer> queue = new LinkedBlockingQueue<>(); final BlockingQueue<Integer> queue = new LinkedBlockingQueue<>();
final int depthToTest = 3; final int depthToTest = 3;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment