Commit d3cea3c5 authored by eroman's avatar eroman Committed by Commit bot

Revert of Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of...

Revert of Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/965113002/)

Reason for revert:
Revert did not help, restoring original patch

Original issue's description:
> Revert of SK_DEBUG when DCHECK_ALWAYS_ON (patchset #1 id:1 of https://codereview.chromium.org/966593002/)
>
> Reason for revert:
> May have caused FontRenderParamsTest failures on Linux debug bots.
>
> Original issue's description:
> > SK_DEBUG when DCHECK_ALWAYS_ON
> >
> > BUG=
> >
> > Committed: https://crrev.com/879405ae813ae4a9bcbd7684d3551420d4980383
> > Cr-Commit-Position: refs/heads/master@{#318557}
>
> TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/6197d8798bb0282d42b69c535b17bd2cd92c3b38
> Cr-Commit-Position: refs/heads/master@{#318581}

TBR=jam@chromium.org,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/963423003

Cr-Commit-Position: refs/heads/master@{#318600}
parent 91cb1747
...@@ -79,6 +79,10 @@ ...@@ -79,6 +79,10 @@
//#define SK_DEBUG //#define SK_DEBUG
//#define SK_RELEASE //#define SK_RELEASE
#ifdef DCHECK_ALWAYS_ON
#undef SK_RELEASE
#define SK_DEBUG
#endif
/* If, in debugging mode, Skia needs to stop (presumably to invoke a debugger) /* If, in debugging mode, Skia needs to stop (presumably to invoke a debugger)
it will call SK_CRASH(). If this is not defined it, it is defined in it will call SK_CRASH(). If this is not defined it, it is defined in
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment