Commit d3dd3038 authored by wittman's avatar wittman Committed by Commit bot

Stack sampling profiler: update to 10% full disable experiment

Stability and performance numbers from the current 50% GPU process enable rate
look good. Move on to the third experiment configuration in the associated bug,
to test performance impact of enabling the profiler for both GPU and browser
processes vs. enabling for neither process.

This CL deviates from the roll out percentages in the bug by performing the
experiment on 10% of launches rather than 50%. The experiment will be enabled
over the holiday period, so the lower percentage will provide enough data while
minimizing data volume differences for the browser process.

BUG=650869

Review-Url: https://codereview.chromium.org/2571483003
Cr-Commit-Position: refs/heads/master@{#437936}
parent d921e149
......@@ -128,7 +128,8 @@ void StackSamplingConfiguration::AppendCommandLineSwitchForChildProcess(
DCHECK(IsBrowserProcess());
if (process_type == switches::kGpuProcess &&
(configuration_ == PROFILE_GPU_PROCESS ||
(configuration_ == PROFILE_CONTROL ||
configuration_ == PROFILE_GPU_PROCESS ||
configuration_ == PROFILE_BROWSER_AND_GPU_PROCESS)) {
command_line->AppendSwitch(switches::kStartStackProfiler);
}
......@@ -180,18 +181,18 @@ StackSamplingConfiguration::GenerateConfiguration() {
return ChooseConfiguration({
{ PROFILE_BROWSER_PROCESS, 0},
{ PROFILE_GPU_PROCESS, 0},
{ PROFILE_BROWSER_AND_GPU_PROCESS, 50},
{ PROFILE_CONTROL, 50},
{ PROFILE_DISABLED, 0}
{ PROFILE_BROWSER_AND_GPU_PROCESS, 80},
{ PROFILE_CONTROL, 10},
{ PROFILE_DISABLED, 10}
});
case version_info::Channel::DEV:
return ChooseConfiguration({
{ PROFILE_BROWSER_PROCESS, 0},
{ PROFILE_GPU_PROCESS, 0},
{ PROFILE_BROWSER_AND_GPU_PROCESS, 50},
{ PROFILE_CONTROL, 50},
{ PROFILE_DISABLED, 0}
{ PROFILE_BROWSER_AND_GPU_PROCESS, 80},
{ PROFILE_CONTROL, 10},
{ PROFILE_DISABLED, 10}
});
default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment