Commit d3e6557e authored by wychen's avatar wychen Committed by Commit bot

Remove enable-touch-hover flag

This CL reverts "Experiment with emulating mouse hover with touch hover
capable devices"

This reverts commit d74bc3e1.

BUG=418188, 617437

Review-Url: https://codereview.chromium.org/2621073002
Cr-Commit-Position: refs/heads/master@{#442886}
parent 8c49df53
......@@ -14698,12 +14698,6 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
Enable "Ok Google"
</message>
<message name="IDS_FLAGS_TOUCH_HOVER_NAME" desc="Name of the 'Enable support for hover capable touchscreens' flag.">
Support for hover capable touchscreens
</message>
<message name="IDS_FLAGS_TOUCH_HOVER_DESCRIPTION" desc="Description of the 'Enable support for hover capable touchscreens' flag.">
Enables hover feature by holding your finger just over the screen to experience a mouseover event.
</message>
<message name="IDS_ALLOW_INSECURE_LOCALHOST" desc="Name of the 'Allow insecure localhost' flag.">
Allow invalid certificates for resources loaded from localhost.
</message>
......
......@@ -1502,9 +1502,6 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_SECCOMP_FILTER_SANDBOX_ANDROID_DESCRIPTION, kOsAndroid,
FEATURE_VALUE_TYPE(features::kSeccompSandboxAndroid)},
#endif // OS_ANDROID
{"enable-touch-hover", IDS_FLAGS_TOUCH_HOVER_NAME,
IDS_FLAGS_TOUCH_HOVER_DESCRIPTION, kOsAndroid,
SINGLE_VALUE_TYPE("enable-touch-hover")},
#if defined(OS_CHROMEOS)
{"enable-wifi-credential-sync", IDS_FLAGS_WIFI_CREDENTIAL_SYNC_NAME,
IDS_FLAGS_WIFI_CREDENTIAL_SYNC_DESCRIPTION, kOsCrOS,
......
......@@ -40,7 +40,6 @@ import android.view.inputmethod.EditorInfo;
import android.view.inputmethod.InputConnection;
import android.view.inputmethod.InputMethodManager;
import org.chromium.base.CommandLine;
import org.chromium.base.ObserverList;
import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.TraceEvent;
......@@ -60,7 +59,6 @@ import org.chromium.content.browser.input.SelectPopup;
import org.chromium.content.browser.input.SelectPopupDialog;
import org.chromium.content.browser.input.SelectPopupDropdown;
import org.chromium.content.browser.input.SelectPopupItem;
import org.chromium.content.common.ContentSwitches;
import org.chromium.content_public.browser.AccessibilitySnapshotCallback;
import org.chromium.content_public.browser.AccessibilitySnapshotNode;
import org.chromium.content_public.browser.ActionModeCallbackHelper;
......@@ -385,9 +383,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
// A ViewAndroidDelegate that delegates to the current container view.
private ViewAndroidDelegate mViewAndroidDelegate;
// A flag to determine if we enable hover feature or not.
private Boolean mEnableTouchHover;
// NOTE: This object will not be released by Android framework until the matching
// ResultReceiver in the InputMethodService (IME app) gets gc'ed.
private ShowKeyboardResultReceiver mShowKeyboardResultReceiver;
......@@ -1565,16 +1560,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
return mBrowserAccessibilityManager.onHoverEvent(offset);
}
// TODO(lanwei): Remove this switch once experimentation is complete -
// crbug.com/418188
if (event.getToolType(0) == MotionEvent.TOOL_TYPE_FINGER) {
if (mEnableTouchHover == null) {
mEnableTouchHover =
CommandLine.getInstance().hasSwitch(ContentSwitches.ENABLE_TOUCH_HOVER);
}
if (!mEnableTouchHover.booleanValue()) return false;
}
if (mNativeContentViewCore != 0) {
nativeSendMouseEvent(mNativeContentViewCore, event.getEventTime(), eventAction,
offset.getX(), offset.getY(), event.getPointerId(0), event.getPressure(0),
......
......@@ -42,9 +42,6 @@ public abstract class ContentSwitches {
// Native switch - chrome_switches::kDisablePopupBlocking
public static final String DISABLE_POPUP_BLOCKING = "disable-popup-blocking";
// Enable mouse hover emulation by holding your finger just over the screen.
public static final String ENABLE_TOUCH_HOVER = "enable-touch-hover";
// Native switch kEnableCredentialManagerAPI
public static final String ENABLE_CREDENTIAL_MANAGER_API = "enable-credential-manager-api";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment