Commit d4229d6d authored by Raphael Kubo da Costa's avatar Raphael Kubo da Costa Committed by Commit Bot

WPT import: Shorten CL commit message.

We are currently hitting an "argument list too long" error in git-cl upload
that is blocking imports.

At least temporarily, stop mentioning the owners for the directories being
changed, and trim the "note to sheriffs" so that the CL message gets
shorter.

Bug: 780055
Change-Id: Icf65268c5f8429c1b18d327d320a5731b1bd0784
Reviewed-on: https://chromium-review.googlesource.com/749062
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: default avatarPhilip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513109}
parent d30df395
...@@ -470,15 +470,8 @@ class TestImporter(object): ...@@ -470,15 +470,8 @@ class TestImporter(object):
description += 'Build: %s\n\n' % build_link description += 'Build: %s\n\n' % build_link
description += ( description += (
'Note to sheriffs: This CL imports external tests and adds\n' 'Note to sheriffs: This is an automatically-generated CL. Please\n'
'expectations for those tests; if this CL is large and causes\n' 'contact ecosystem-infra@chromium.org in case of problems.\n\n')
'a few new failures, please fix the failures by adding new\n'
'lines to TestExpectations rather than reverting. See:\n'
'https://chromium.googlesource.com'
'/chromium/src/+/master/docs/testing/web_platform_tests.md\n\n')
if directory_owners:
description += self._format_directory_owners(directory_owners) + '\n\n'
# Move any No-Export tag to the end of the description. # Move any No-Export tag to the end of the description.
description = description.replace('No-Export: true', '') description = description.replace('No-Export: true', '')
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
import datetime import datetime
import json import json
import unittest
from webkitpy.common.checkout.git_mock import MockGit from webkitpy.common.checkout.git_mock import MockGit
from webkitpy.common.host_mock import MockHost from webkitpy.common.host_mock import MockHost
...@@ -267,12 +268,8 @@ class TestImporterTest(LoggingTestCase): ...@@ -267,12 +268,8 @@ class TestImporterTest(LoggingTestCase):
self.assertEqual( self.assertEqual(
description, description,
'Last commit message\n\n' 'Last commit message\n\n'
'Note to sheriffs: This CL imports external tests and adds\n' 'Note to sheriffs: This is an automatically-generated CL. Please\n'
'expectations for those tests; if this CL is large and causes\n' 'contact ecosystem-infra@chromium.org in case of problems.\n\n'
'a few new failures, please fix the failures by adding new\n'
'lines to TestExpectations rather than reverting. See:\n'
'https://chromium.googlesource.com'
'/chromium/src/+/master/docs/testing/web_platform_tests.md\n\n'
'No-Export: true') 'No-Export: true')
self.assertEqual(host.executive.calls, [['git', 'log', '-1', '--format=%B']]) self.assertEqual(host.executive.calls, [['git', 'log', '-1', '--format=%B']])
...@@ -298,6 +295,7 @@ class TestImporterTest(LoggingTestCase): ...@@ -298,6 +295,7 @@ class TestImporterTest(LoggingTestCase):
'No-Export: true', 'No-Export: true',
description) description)
@unittest.skip("http://crbug.com/780055")
def test_cl_description_with_directory_owners(self): def test_cl_description_with_directory_owners(self):
host = MockHost() host = MockHost()
host.executive = MockExecutive(output='Last commit message\n\n') host.executive = MockExecutive(output='Last commit message\n\n')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment