MD Extensions: Disable "Extension options" button when extension is disabled.

Convert the "Extension options" row to a cr-link-row and leverage the existing
styling for the disabled case.

Bug: 794756
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7139e20a17d5e0ac5c85f0e1da7a5ad3bd2ab3d9
Reviewed-on: https://chromium-review.googlesource.com/826484
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524548}

chrome/browser/resources/md_extensions/detail_view.html

@@ -357,13 +357,12 @@
             </template>
           </div>
         </template>
-        <div class="section control-line actionable" id="extensions-options"
-            on-tap="onOptionsTap_"
-            hidden$="[[!shouldShowOptionsLink_(data.*)]]">
-          <span id="optionLabel">$i18n{itemOptions}</span>
-          <button class="icon-external" is="paper-icon-button-light"
-              aria-labelledby="optionLabel" actionable></button>
-        </div>
+        <button class="hr" is="cr-link-row" id="extensions-options"
+            disabled="[[!isEnabled_(data.state)]]"
+            hidden="[[!shouldShowOptionsLink_(data.*)]]"
+            icon-class="icon-external" label="$i18n{itemOptions}"
+            on-tap="onExtensionOptionsTap_">
+        </button>
         <button class="hr" hidden="[[!data.manifestHomePageUrl.length]]"
             is="cr-link-row" icon-class="icon-external" id="developerWebsite"
             label="$i18n{developerWebsite}" on-tap="onDeveloperWebSiteTap_">

chrome/browser/resources/md_extensions/detail_view.js

@@ -146,7 +146,7 @@ cr.define('extensions', function() {
     },
 
     /** @private */
-    onOptionsTap_: function() {
+    onExtensionOptionsTap_: function() {
       this.delegate.showItemOptionsPage(this.data);
     },
 

chrome/test/data/webui/extensions/extension_detail_view_test.js

@@ -127,6 +127,14 @@ cr.define('extension_detail_view_tests', function() {
       Polymer.dom.flush();
       expectTrue(testIsVisible('#id-section'));
       expectTrue(testIsVisible('#inspectable-views'));
+
+      // Ensure that the "Extension options" button is disabled when the item
+      // itself is disabled.
+      var extensionOptions = item.$$('#extensions-options');
+      assertFalse(extensionOptions.disabled);
+      item.set('data.state', chrome.developerPrivate.ExtensionState.DISABLED);
+      Polymer.dom.flush();
+      assertTrue(extensionOptions.disabled);
     });
 
     test(assert(TestNames.LayoutSource), function() {