Commit d455e1d9 authored by eric@webkit.org's avatar eric@webkit.org

2010-01-31 Kwang Yul Seo <skyul@company100.net>

        Reviewed by Darin Adler.

        Limit the scope of packing alignment to avoid MSVC C4103 warning.
        https://bugs.webkit.org/show_bug.cgi?id=34390

        Use pack(push, 16) and pack(pop) to limit the scope of packing
        alignment change.

        * bindings/js/JSSVGPODTypeWrapper.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 191b3814
2010-01-31 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Limit the scope of packing alignment to avoid MSVC C4103 warning.
https://bugs.webkit.org/show_bug.cgi?id=34390
Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.
* bindings/js/JSSVGPODTypeWrapper.h:
2010-01-31 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
......
......@@ -71,7 +71,7 @@ public:
// GetterMethod and SetterMethod are each 12 bytes. We have to pack to a size
// greater than or equal to that to avoid an alignment warning (C4121). 16 is
// the next-largest size allowed for packing, so we use that.
#pragma pack(16)
#pragma pack(push, 16)
#endif
template<typename PODType, typename PODTypeCreator>
class JSSVGDynamicPODTypeWrapper : public JSSVGPODTypeWrapper<PODType> {
......@@ -113,6 +113,9 @@ private:
GetterMethod m_getter;
SetterMethod m_setter;
};
#if COMPILER(MSVC)
#pragma pack(pop)
#endif
// Represents a JS wrapper object for SVG POD types (not for SVGAnimated* classes). Any modification to the SVG POD
// types don't cause any updates unlike JSSVGDynamicPODTypeWrapper. This class is used for return values (ie. getBBox())
......@@ -175,7 +178,7 @@ private:
// GetterMethod and SetterMethod are each 12 bytes. We have to pack to a size
// greater than or equal to that to avoid an alignment warning (C4121). 16 is
// the next-largest size allowed for packing, so we use that.
#pragma pack(16)
#pragma pack(push, 16)
#endif
template<typename PODType, typename ParentType>
class JSSVGStaticPODTypeWrapperWithParent : public JSSVGPODTypeWrapper<PODType> {
......@@ -310,6 +313,9 @@ struct PODTypeWrapperCacheInfo {
GetterMethod getter;
SetterMethod setter;
};
#if COMPILER(MSVC)
#pragma pack(pop)
#endif
template<typename PODType, typename PODTypeCreator>
struct PODTypeWrapperCacheInfoHash {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment