Commit d48d14e2 authored by Hans Wennborg's avatar Hans Wennborg Committed by Commit Bot

Clang build script: Don't run check-all on the bootstrap compiler on Darwin

Some libc++ tests fail when the mac_upload_clang bot is run on LUCI
instead of Buildbot, and it's not clear why.

Since we don't really care about testing libc++ here, don't run those
tests to unblock the LUCI migration.

Bug: 731375
Change-Id: I273e0345098795cf27cb527873b04ddf8945bb83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680546
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Reviewed-by: default avatarReid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675700}
parent db9b03b0
...@@ -477,9 +477,13 @@ def main(): ...@@ -477,9 +477,13 @@ def main():
msvc_arch='x64') msvc_arch='x64')
RunCommand(['ninja'], msvc_arch='x64') RunCommand(['ninja'], msvc_arch='x64')
if args.run_tests: if args.run_tests:
test_targets = [ 'check-all' ]
if sys.platform == 'darwin':
# TODO(crbug.com/731375): Run check-all on Darwin too.
test_targets = [ 'check-llvm', 'check-clang', 'check-builtins' ]
if sys.platform == 'win32': if sys.platform == 'win32':
CopyDiaDllTo(os.path.join(LLVM_BOOTSTRAP_DIR, 'bin')) CopyDiaDllTo(os.path.join(LLVM_BOOTSTRAP_DIR, 'bin'))
RunCommand(['ninja', 'check-all'], msvc_arch='x64') RunCommand(['ninja'] + test_targets, msvc_arch='x64')
RunCommand(['ninja', 'install'], msvc_arch='x64') RunCommand(['ninja', 'install'], msvc_arch='x64')
if sys.platform == 'win32': if sys.platform == 'win32':
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment