Commit d4a43f22 authored by inferno's avatar inferno Committed by Commit bot

Revert of Disable container overflow check on Linux and Mac. (patchset #2...

Revert of Disable container overflow check on Linux and Mac. (patchset #2 id:20001 of https://codereview.chromium.org/951083002/)

Reason for revert:
Container overflow is stable on linux, we can safely revert it.

Original issue's description:
> Disable container overflow check on Linux and Mac.
>
> BUG=459632
> TBR=glider@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/6c3ce96dedaf8f23fce9cbd9c5279fe20c531ac6
> Cr-Commit-Position: refs/heads/master@{#317681}

TBR=marcheu@chromium.org,glider@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459632

Review URL: https://codereview.chromium.org/1069793002

Cr-Commit-Position: refs/heads/master@{#324235}
parent a83e4009
......@@ -66,8 +66,6 @@ void _sanitizer_options_link_helper() { }
// so the slow unwinder may not work properly.
// detect_stack_use_after_return=1 - use fake stack to delay the reuse of
// stack allocations and detect stack-use-after-return errors.
// detect_container_overflow=0 - do not detect overflows in containers
// until crbug.com/459632 is fixed.
#if defined(OS_LINUX)
#if defined(GOOGLE_CHROME_BUILD)
// Default AddressSanitizer options for the official build. These do not affect
......@@ -76,22 +74,20 @@ void _sanitizer_options_link_helper() { }
const char kAsanDefaultOptions[] =
"legacy_pthread_cond=1 malloc_context_size=5 strict_memcmp=0 "
"symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 "
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_container_overflow=0 ";
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
#else
// Default AddressSanitizer options for buildbots and non-official builds.
const char *kAsanDefaultOptions =
"strict_memcmp=0 symbolize=false check_printf=1 use_sigaltstack=1 "
"detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_stack_use_after_return=1 detect_container_overflow=0 ";
"detect_stack_use_after_return=1 ";
#endif // GOOGLE_CHROME_BUILD
#elif defined(OS_MACOSX)
const char *kAsanDefaultOptions =
"strict_memcmp=0 replace_intrin=0 check_printf=1 use_sigaltstack=1 "
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
"detect_stack_use_after_return=1 detect_odr_violation=0 "
"detect_container_overflow=0 ";
"detect_stack_use_after_return=1 detect_odr_violation=0 ";
static const char kNaClDefaultOptions[] = "handle_segv=0";
static const char kNaClFlag[] = "--type=nacl-loader";
#endif // OS_LINUX
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment