Commit d4c771eb authored by mrefaat's avatar mrefaat Committed by Commit Bot

Remove ordering restriction for VoiceSearchTabHelper creation

Tab no longer use the VoiceSearchTabHelper, so ordering is not needed
any more

Bug: 778416
Change-Id: I37a84f76de97be5af8956eb829808f86ac839468
Reviewed-on: https://chromium-review.googlesource.com/c/1353937Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611943}
parent b6152020
...@@ -57,12 +57,6 @@ ...@@ -57,12 +57,6 @@
#import "ios/web/public/web_state/web_state.h" #import "ios/web/public/web_state/web_state.h"
void AttachTabHelpers(web::WebState* web_state, bool for_prerender) { void AttachTabHelpers(web::WebState* web_state, bool for_prerender) {
// Tab's WebStateObserver callbacks expect VoiceSearchNavigationTabHelper's
// callbacks to be executed first so that state stays in sync.
// TODO(crbug.com/778416): Remove this ordering requirement by relying solely
// on the tab helper without going through Tab.
VoiceSearchNavigationTabHelper::CreateForWebState(web_state);
// TabIdHelper sets up the tab ID which is required for the creation of the // TabIdHelper sets up the tab ID which is required for the creation of the
// Tab by LegacyTabHelper. // Tab by LegacyTabHelper.
TabIdTabHelper::CreateForWebState(web_state); TabIdTabHelper::CreateForWebState(web_state);
...@@ -79,6 +73,7 @@ void AttachTabHelpers(web::WebState* web_state, bool for_prerender) { ...@@ -79,6 +73,7 @@ void AttachTabHelpers(web::WebState* web_state, bool for_prerender) {
NSString* tab_id = TabIdTabHelper::FromWebState(web_state)->tab_id(); NSString* tab_id = TabIdTabHelper::FromWebState(web_state)->tab_id();
NetworkActivityIndicatorTabHelper::CreateForWebState(web_state, tab_id); NetworkActivityIndicatorTabHelper::CreateForWebState(web_state, tab_id);
VoiceSearchNavigationTabHelper::CreateForWebState(web_state);
IOSChromeSyncedTabDelegate::CreateForWebState(web_state); IOSChromeSyncedTabDelegate::CreateForWebState(web_state);
InfoBarManagerImpl::CreateForWebState(web_state); InfoBarManagerImpl::CreateForWebState(web_state);
IOSSecurityStateTabHelper::CreateForWebState(web_state); IOSSecurityStateTabHelper::CreateForWebState(web_state);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment