Commit d4e55cc9 authored by Sky Malice's avatar Sky Malice Committed by Commit Bot

[Feed] Import feed@159a13d840ef3638205987e117f746fb12514edf

DEPS rolled out of sequence for performance improvement when processing
network response.

Specifics:
       +66,344 bytes main lib size
      +514,628 bytes main dex size
      +825,244 bytes normalized apk size
InstallSize:
      +312,903 bytes APK size
      +915,017 bytes Estimated installed size (Android Go)
    +2,392,000 bytes Estimated installed size
InstallBreakdown (+2,392,205 bytes):
        +3,006 bytes unwind_cfi (dev and canary only) size
        +2,650 bytes Non-compiled Android resources size
       +66,344 bytes Native code size
          +570 bytes Package metadata size
    +2,302,943 bytes Java code size
       +16,692 bytes Compiled Android resources size
Dex:
        +2,632 entries fields
        +3,684 entries methods
          +841 entries types
        +1,852 entries strings

Bug: 916791
Change-Id: I8dd17fa9ad20ec924dcaa5801e2f7fe85686f244
Reviewed-on: https://chromium-review.googlesource.com/c/1459321Reviewed-by: default avatarGang Wu <gangwu@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630095}
parent cfac8742
...@@ -202,7 +202,7 @@ vars = { ...@@ -202,7 +202,7 @@ vars = {
# Three lines of non-changing comments so that # Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed # the commit queue can handle CLs rolling feed
# and whatever else without interference from each other. # and whatever else without interference from each other.
'feed_revision': 'd518125afbfeb9a230dab5db75122ec14028b395', 'feed_revision': '159a13d840ef3638205987e117f746fb12514edf',
# Three lines of non-changing comments so that # Three lines of non-changing comments so that
# the commit queue can handle CLs rolling android_sdk_build-tools_version # the commit queue can handle CLs rolling android_sdk_build-tools_version
# and whatever else without interference from each other. # and whatever else without interference from each other.
......
...@@ -10,6 +10,8 @@ import com.google.android.libraries.feed.api.stream.ScrollListener; ...@@ -10,6 +10,8 @@ import com.google.android.libraries.feed.api.stream.ScrollListener;
import com.google.android.libraries.feed.host.logging.ActionType; import com.google.android.libraries.feed.host.logging.ActionType;
import com.google.android.libraries.feed.host.logging.BasicLoggingApi; import com.google.android.libraries.feed.host.logging.BasicLoggingApi;
import com.google.android.libraries.feed.host.logging.ContentLoggingData; import com.google.android.libraries.feed.host.logging.ContentLoggingData;
import com.google.android.libraries.feed.host.logging.ElementLoggingData;
import com.google.android.libraries.feed.host.logging.ElementType;
import com.google.android.libraries.feed.host.logging.SpinnerType; import com.google.android.libraries.feed.host.logging.SpinnerType;
import org.chromium.base.annotations.JNINamespace; import org.chromium.base.annotations.JNINamespace;
...@@ -145,24 +147,6 @@ public class FeedLoggingBridge implements BasicLoggingApi { ...@@ -145,24 +147,6 @@ public class FeedLoggingBridge implements BasicLoggingApi {
// TODO(https://crbug.com/924739): Implementation. // TODO(https://crbug.com/924739): Implementation.
} }
@Override
public void onInterestHeaderView(ContentLoggingData data) {
// Bridge could have been destroyed for policy when this is called.
// See https://crbug.com/901414.
if (mNativeFeedLoggingBridge == 0) return;
// TODO(https://crbug.com/924739): Implementation.
}
@Override
public void onInterestHeaderClicked(ContentLoggingData data) {
// Bridge could have been destroyed for policy when this is called.
// See https://crbug.com/901414.
if (mNativeFeedLoggingBridge == 0) return;
// TODO(https://crbug.com/924739): Implementation.
}
@Override @Override
public void onOpenedWithContent(int timeToPopulateMs, int contentCount) { public void onOpenedWithContent(int timeToPopulateMs, int contentCount) {
// Bridge could have been destroyed for policy when this is called. // Bridge could have been destroyed for policy when this is called.
...@@ -204,6 +188,16 @@ public class FeedLoggingBridge implements BasicLoggingApi { ...@@ -204,6 +188,16 @@ public class FeedLoggingBridge implements BasicLoggingApi {
// TODO(https://crbug.com/924739): Implementation. // TODO(https://crbug.com/924739): Implementation.
} }
@Override
public void onVisualElementClicked(ElementLoggingData data, @ElementType int elementType) {
// TODO(https://crbug.com/924739): Implementation.
}
@Override
public void onVisualElementViewed(ElementLoggingData data, @ElementType int elementType) {
// TODO(https://crbug.com/924739): Implementation.
}
/** /**
* Reports how long a user spends on the page. * Reports how long a user spends on the page.
* *
......
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
This diff was suppressed by a .gitattributes entry.
...@@ -2,7 +2,7 @@ Name: Feed ...@@ -2,7 +2,7 @@ Name: Feed
Short name: feed Short name: feed
URL: https://chromium.googlesource.com/feed URL: https://chromium.googlesource.com/feed
Version: 0 Version: 0
Revision: d518125afbfeb9a230dab5db75122ec14028b395 Revision: 159a13d840ef3638205987e117f746fb12514edf
License: Apache 2.0 License: Apache 2.0
License File: LICENSE License File: LICENSE
Security Critical: yes Security Critical: yes
......
...@@ -105,6 +105,7 @@ feed_lib_java_sources = [ ...@@ -105,6 +105,7 @@ feed_lib_java_sources = [
"src/src/main/java/com/google/android/libraries/feed/feedactionparser/FeedActionParser.java", "src/src/main/java/com/google/android/libraries/feed/feedactionparser/FeedActionParser.java",
"src/src/main/java/com/google/android/libraries/feed/feedactionparser/FeedActionParserFactory.java", "src/src/main/java/com/google/android/libraries/feed/feedactionparser/FeedActionParserFactory.java",
"src/src/main/java/com/google/android/libraries/feed/feedactionparser/internal/ActionTypeConverter.java", "src/src/main/java/com/google/android/libraries/feed/feedactionparser/internal/ActionTypeConverter.java",
"src/src/main/java/com/google/android/libraries/feed/feedactionparser/internal/ElementTypeConverter.java",
"src/src/main/java/com/google/android/libraries/feed/feedactionparser/internal/PietFeedActionPayloadRetriever.java", "src/src/main/java/com/google/android/libraries/feed/feedactionparser/internal/PietFeedActionPayloadRetriever.java",
"src/src/main/java/com/google/android/libraries/feed/feedactionreader/FeedActionReader.java", "src/src/main/java/com/google/android/libraries/feed/feedactionreader/FeedActionReader.java",
"src/src/main/java/com/google/android/libraries/feed/feedapplifecyclelistener/FeedAppLifecycleListener.java", "src/src/main/java/com/google/android/libraries/feed/feedapplifecyclelistener/FeedAppLifecycleListener.java",
...@@ -164,6 +165,8 @@ feed_lib_java_sources = [ ...@@ -164,6 +165,8 @@ feed_lib_java_sources = [
"src/src/main/java/com/google/android/libraries/feed/host/logging/ActionType.java", "src/src/main/java/com/google/android/libraries/feed/host/logging/ActionType.java",
"src/src/main/java/com/google/android/libraries/feed/host/logging/BasicLoggingApi.java", "src/src/main/java/com/google/android/libraries/feed/host/logging/BasicLoggingApi.java",
"src/src/main/java/com/google/android/libraries/feed/host/logging/ContentLoggingData.java", "src/src/main/java/com/google/android/libraries/feed/host/logging/ContentLoggingData.java",
"src/src/main/java/com/google/android/libraries/feed/host/logging/ElementLoggingData.java",
"src/src/main/java/com/google/android/libraries/feed/host/logging/ElementType.java",
"src/src/main/java/com/google/android/libraries/feed/host/logging/LoggingApi.java", "src/src/main/java/com/google/android/libraries/feed/host/logging/LoggingApi.java",
"src/src/main/java/com/google/android/libraries/feed/host/logging/SpinnerType.java", "src/src/main/java/com/google/android/libraries/feed/host/logging/SpinnerType.java",
"src/src/main/java/com/google/android/libraries/feed/host/network/HttpHeader.java", "src/src/main/java/com/google/android/libraries/feed/host/network/HttpHeader.java",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment