Commit d52c54a8 authored by aa@chromium.org's avatar aa@chromium.org

Only show load warnings for extensions under development.

BUG=138862
TBR=arv@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148606 0039d316-1c4b-4281-b951-d872f2087c98
parent 9902c4da
...@@ -192,19 +192,21 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue( ...@@ -192,19 +192,21 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
} }
// Add install warnings (these are not the same as warnings!). // Add install warnings (these are not the same as warnings!).
const Extension::InstallWarningVector& install_warnings = if (extension->location() == Extension::LOAD) {
extension->install_warnings(); const Extension::InstallWarningVector& install_warnings =
if (!install_warnings.empty()) { extension->install_warnings();
scoped_ptr<ListValue> list(new ListValue()); if (!install_warnings.empty()) {
for (Extension::InstallWarningVector::const_iterator it = scoped_ptr<ListValue> list(new ListValue());
install_warnings.begin(); it != install_warnings.end(); ++it) { for (Extension::InstallWarningVector::const_iterator it =
DictionaryValue* item = new DictionaryValue(); install_warnings.begin(); it != install_warnings.end(); ++it) {
item->SetBoolean("isHTML", DictionaryValue* item = new DictionaryValue();
it->format == Extension::InstallWarning::FORMAT_HTML); item->SetBoolean("isHTML",
item->SetString("message", it->message); it->format == Extension::InstallWarning::FORMAT_HTML);
list->Append(item); item->SetString("message", it->message);
list->Append(item);
}
extension_data->Set("installWarnings", list.release());
} }
extension_data->Set("installWarnings", list.release());
} }
return extension_data; return extension_data;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment