Revert making trying to authorize a nonsense device id a bad_message.

As it happens, renderers actually do this, and we don't want to
unnecessarily crash them. Instead, use the previous behaviour of
returning OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND instead.

One way to trigger a nonsense id being sent to the browser is by using
the setSinkId method of an HTMLMediaElement.

BUG=671167

Review-Url: https://codereview.chromium.org/2561343002
Cr-Commit-Position: refs/heads/master@{#437933}

content/browser/renderer_host/media/audio_output_authorization_handler.cc

@@ -82,8 +82,8 @@ void AudioOutputAuthorizationHandler::RequestDeviceAuthorization(
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   if (!IsValidDeviceId(device_id)) {
-    bad_message::ReceivedBadMessage(render_process_id_,
-                                    bad_message::AOAH_NONSENSE_DEVICE_ID);
+    cb.Run(media::OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND, false,
+           media::AudioParameters::UnavailableDeviceParams(), std::string());
     return;
   }
 

content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc

@@ -260,8 +260,7 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
   SyncWithAllThreads();
 }
 
-TEST_F(AudioOutputAuthorizationHandlerTest,
-       AuthorizeInvalidDeviceId_BadMessage) {
+TEST_F(AudioOutputAuthorizationHandlerTest, AuthorizeInvalidDeviceId_NotFound) {
   std::unique_ptr<TestBrowserContext> context =
       base::MakeUnique<TestBrowserContext>();
   std::unique_ptr<MockRenderProcessHost> RPH =
@@ -272,7 +271,10 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
           GetAudioManager(), GetMediaStreamManager(), RPH->GetID(), kSalt);
   EXPECT_EQ(RPH->bad_msg_count(), 0);
 
-  EXPECT_CALL(listener, MockAuthorizationCallback(_, _, _, _)).Times(0);
+  EXPECT_CALL(listener,
+              MockAuthorizationCallback(
+                  media::OUTPUT_DEVICE_STATUS_ERROR_NOT_FOUND, _, _, _))
+      .Times(1);
 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
@@ -281,7 +283,9 @@ TEST_F(AudioOutputAuthorizationHandlerTest,
                   kInvalidDeviceId, SecurityOrigin(), listener.GetCallback())));
 
   SyncWithAllThreads();
-  EXPECT_EQ(RPH->bad_msg_count(), 1);
+  // It is possible to request an invalid device id from JS APIs,
+  // so we don't want to crash the renderer for this.
+  EXPECT_EQ(RPH->bad_msg_count(), 0);
   BrowserThread::DeleteSoon(BrowserThread::IO, FROM_HERE, handler.release());
   SyncWithAllThreads();
   RPH.reset();

content/browser/renderer_host/media/audio_renderer_host_unittest.cc

@@ -609,9 +609,8 @@ TEST_F(AudioRendererHostTest, CreateDeviceWithBadSecurityOrigin) {
 }
 
 TEST_F(AudioRendererHostTest, CreateInvalidDevice) {
-  Create(kInvalidDeviceId, url::Origin(GURL(kSecurityOrigin)), true, false);
+  Create(kInvalidDeviceId, url::Origin(GURL(kSecurityOrigin)), true, true);
   Close();
-  AssertBadMsgReported();
 }
 
 TEST_F(AudioRendererHostTest, CreateFailsForInvalidRenderFrame) {