Commit d55838aa authored by trchen's avatar trchen Committed by Commit bot

Re-enable ContentViewPopupZoomerTest

PopupZoomer will stick to the initial container view and will refuse to switch
when ContentViewCore.setContainerView() is invoked. This is by-design as we
never intended to support disambiguation popup for WebView or fullscreen video.

Removes @RerunWithUpdatedContainerView and re-enables the test.

BUG=167045

Review URL: https://codereview.chromium.org/1611863002

Cr-Commit-Position: refs/heads/master@{#370782}
parent 9fca1d27
......@@ -4,10 +4,11 @@
package org.chromium.content.browser;
import android.test.suitebuilder.annotation.MediumTest;
import android.view.View;
import android.view.ViewGroup;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
......@@ -78,10 +79,8 @@ public class ContentViewPopupZoomerTest extends ContentShellTestBase {
/**
* Tests that shows a zoomer popup and makes sure it has valid dimensions.
*/
//@MediumTest
//@Feature({"Browser"})
//@RerunWithUpdatedContainerView -> this test should pass with this new annotation.
@DisabledTest // crbug.com/167045
@MediumTest
@Feature({"Browser"})
public void testPopupZoomerShowsUp() throws InterruptedException, TimeoutException {
launchContentShellWithUrl(generateTestUrl(100, 15, "clickme"));
waitForActiveShellToBeDoneLoading();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment