Commit d55d0e07 authored by rbpotter's avatar rbpotter Committed by Commit Bot

Delete kSettingsPolymer3 flag

The flag is no longer respected. Delete the flag and all references to
it.

Bug: 1069258
Change-Id: I0d5040eef178ab5d93cd45d244374f17a424f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150277
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatardpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759822}
parent 7c5b96d5
...@@ -95,11 +95,6 @@ const base::Feature kWebUITabStrip{"WebUITabStrip", ...@@ -95,11 +95,6 @@ const base::Feature kWebUITabStrip{"WebUITabStrip",
const base::Feature kWebUITabStripDemoOptions{ const base::Feature kWebUITabStripDemoOptions{
"WebUITabStripDemoOptions", base::FEATURE_DISABLED_BY_DEFAULT}; "WebUITabStripDemoOptions", base::FEATURE_DISABLED_BY_DEFAULT};
// Makes chrome://settings serve the Polymer 3 version of that page.
// https://crbug.com/1026426.
const base::Feature kSettingsPolymer3{"SettingsPolymer3",
base::FEATURE_ENABLED_BY_DEFAULT};
// Enables friendly settings for the |chrome://settings/syncSetup| page. // Enables friendly settings for the |chrome://settings/syncSetup| page.
// https://crbug.com/1035421. // https://crbug.com/1035421.
const base::Feature kSyncSetupFriendlySettings{ const base::Feature kSyncSetupFriendlySettings{
......
...@@ -52,8 +52,6 @@ extern const base::Feature kWebUITabStrip; ...@@ -52,8 +52,6 @@ extern const base::Feature kWebUITabStrip;
extern const base::Feature kWebUITabStripDemoOptions; extern const base::Feature kWebUITabStripDemoOptions;
extern const base::Feature kSettingsPolymer3;
extern const base::Feature kSyncSetupFriendlySettings; extern const base::Feature kSyncSetupFriendlySettings;
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
......
...@@ -61,10 +61,8 @@ var CrComponentsCertificateManagerV3Test = ...@@ -61,10 +61,8 @@ var CrComponentsCertificateManagerV3Test =
/** @override */ /** @override */
get featureList() { get featureList() {
return { return {
enabled: [ enabled: ['network::features::kOutOfBlinkCors'],
'network::features::kOutOfBlinkCors', disabled: [],
'features::kSettingsPolymer3',
]
}; };
} }
}; };
......
...@@ -320,10 +320,8 @@ var CrElementsPolicyPrefIndicatorV3Test = ...@@ -320,10 +320,8 @@ var CrElementsPolicyPrefIndicatorV3Test =
/** @override */ /** @override */
get featureList() { get featureList() {
return { return {
enabled: [ enabled: ['network::features::kOutOfBlinkCors'],
'network::features::kOutOfBlinkCors', disabled: [],
'features::kSettingsPolymer3',
]
}; };
} }
}; };
......
...@@ -10,7 +10,6 @@ GEN_INCLUDE([ ...@@ -10,7 +10,6 @@ GEN_INCLUDE([
'//chrome/test/data/webui/polymer_browser_test_base.js', '//chrome/test/data/webui/polymer_browser_test_base.js',
]); ]);
GEN('#include "chrome/browser/ui/ui_features.h"');
GEN('#include "services/network/public/cpp/features.h"'); GEN('#include "services/network/public/cpp/features.h"');
/** /**
...@@ -79,10 +78,7 @@ SettingsAccessibilityV3Test.prototype = { ...@@ -79,10 +78,7 @@ SettingsAccessibilityV3Test.prototype = {
/** @override */ /** @override */
featureList: { featureList: {
enabled: [ enabled: ['network::features::kOutOfBlinkCors'],
'network::features::kOutOfBlinkCors',
'features::kSettingsPolymer3',
],
disabled: [], disabled: [],
}, },
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
GEN_INCLUDE(['//chrome/test/data/webui/polymer_browser_test_base.js']); GEN_INCLUDE(['//chrome/test/data/webui/polymer_browser_test_base.js']);
GEN('#include "build/branding_buildflags.h"'); GEN('#include "build/branding_buildflags.h"');
GEN('#include "chrome/browser/ui/ui_features.h"');
GEN('#include "chrome/common/chrome_features.h"'); GEN('#include "chrome/common/chrome_features.h"');
GEN('#include "components/autofill/core/common/autofill_features.h"'); GEN('#include "components/autofill/core/common/autofill_features.h"');
GEN('#include "components/password_manager/core/common/password_manager_features.h"'); GEN('#include "components/password_manager/core/common/password_manager_features.h"');
...@@ -35,7 +34,6 @@ var CrSettingsV3BrowserTest = class extends PolymerTest { ...@@ -35,7 +34,6 @@ var CrSettingsV3BrowserTest = class extends PolymerTest {
return { return {
enabled: [ enabled: [
'network::features::kOutOfBlinkCors', 'network::features::kOutOfBlinkCors',
'features::kSettingsPolymer3',
...(this.featureListInternal.enabled || []), ...(this.featureListInternal.enabled || []),
], ],
disabled: this.featureListInternal.disabled || [], disabled: this.featureListInternal.disabled || [],
......
...@@ -7,8 +7,6 @@ ...@@ -7,8 +7,6 @@
// Polymer BrowserTest fixture. // Polymer BrowserTest fixture.
GEN_INCLUDE(['//chrome/test/data/webui/polymer_interactive_ui_test.js']); GEN_INCLUDE(['//chrome/test/data/webui/polymer_interactive_ui_test.js']);
GEN('#include "chrome/browser/ui/ui_features.h"');
/** Test fixture for shared Polymer 3 elements. */ /** Test fixture for shared Polymer 3 elements. */
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
var CrSettingsV3InteractiveUITest = class extends PolymerInteractiveUITest { var CrSettingsV3InteractiveUITest = class extends PolymerInteractiveUITest {
...@@ -24,11 +22,6 @@ var CrSettingsV3InteractiveUITest = class extends PolymerInteractiveUITest { ...@@ -24,11 +22,6 @@ var CrSettingsV3InteractiveUITest = class extends PolymerInteractiveUITest {
'//chrome/test/data/webui/mocha_adapter.js', '//chrome/test/data/webui/mocha_adapter.js',
]; ];
} }
/** @override */
get featureList() {
return {enabled: ['features::kSettingsPolymer3'], disabled: []};
}
}; };
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
......
...@@ -2,7 +2,6 @@ ...@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
GEN('#include "chrome/browser/ui/ui_features.h"');
GEN('#include "services/network/public/cpp/features.h"'); GEN('#include "services/network/public/cpp/features.h"');
/** /**
...@@ -30,10 +29,7 @@ SettingsIdleLoadV3BrowserTest.prototype = { ...@@ -30,10 +29,7 @@ SettingsIdleLoadV3BrowserTest.prototype = {
/** @override */ /** @override */
get featureList() { get featureList() {
return { return {
enabled: [ enabled: ['network::features::kOutOfBlinkCors'],
'network::features::kOutOfBlinkCors',
'features::kSettingsPolymer3',
],
disabled: [], disabled: [],
}; };
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment