Commit d569324f authored by Filip Gorski's avatar Filip Gorski Committed by Commit Bot

[NTP] Remove NTP.* RAPPOR metrics

Bug: 1031595
Change-Id: If0f9c8625de099c730cbf2fc909efdec1b21245b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065415
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Auto-Submit: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743395}
parent 49bc122a
......@@ -17,7 +17,6 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.preferences.Pref;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.rappor.RapporServiceBridge;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.EmptyTabModelSelectorObserver;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
......@@ -81,12 +80,6 @@ public final class NewTabPageUma {
/** The number of possible actions. */
private static final int NUM_ACTIONS = 13;
/** User navigated to a page using the omnibox. */
private static final int RAPPOR_ACTION_NAVIGATED_USING_OMNIBOX = 0;
/** User navigated to a page using one of the suggested tiles. */
public static final int RAPPOR_ACTION_VISITED_SUGGESTED_TILE = 1;
/** Regular NTP impression (usually when a new tab is opened). */
public static final int NTP_IMPRESSION_REGULAR = 0;
......@@ -184,25 +177,6 @@ public final class NewTabPageUma {
} else {
recordAction(ACTION_NAVIGATED_USING_OMNIBOX);
}
recordExplicitUserNavigation(destinationUrl, RAPPOR_ACTION_NAVIGATED_USING_OMNIBOX);
}
}
/**
* Record the eTLD+1 for a website explicitly visited by the user, using Rappor.
*/
public static void recordExplicitUserNavigation(String destinationUrl, int rapporMetric) {
switch (rapporMetric) {
case RAPPOR_ACTION_NAVIGATED_USING_OMNIBOX:
RapporServiceBridge.sampleDomainAndRegistryFromURL(
"NTP.ExplicitUserAction.PageNavigation.OmniboxNonSearch", destinationUrl);
return;
case RAPPOR_ACTION_VISITED_SUGGESTED_TILE:
RapporServiceBridge.sampleDomainAndRegistryFromURL(
"NTP.ExplicitUserAction.PageNavigation.NTPTileClick", destinationUrl);
return;
default:
return;
}
}
......
......@@ -130,8 +130,6 @@ public class TileGroupDelegateImpl implements TileGroup.Delegate {
private void recordOpenedTile(Tile tile) {
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_MOST_VISITED_TILE);
RecordUserAction.record("MobileNTPMostVisited");
NewTabPageUma.recordExplicitUserNavigation(
tile.getUrl(), NewTabPageUma.RAPPOR_ACTION_VISITED_SUGGESTED_TILE);
mMostVisitedSites.recordOpenedMostVisitedItem(tile);
}
}
......@@ -119,25 +119,6 @@ components/rappor/rappor_parameters.h.
</summary>
</rappor-metric>
<rappor-metric name="NTP.ExplicitUserAction.PageNavigation.NTPTileClick"
type="UMA_RAPPOR_TYPE">
<owner>knn@chromium.org</owner>
<summary>
The eTLD+1 of the website visited by a user by clicking on the tile in the
NewTabPage.
</summary>
</rappor-metric>
<rappor-metric name="NTP.ExplicitUserAction.PageNavigation.OmniboxNonSearch"
type="UMA_RAPPOR_TYPE">
<owner>knn@chromium.org</owner>
<summary>
The eTLD+1 of the website visited by a user by typing the URL in the omnibox
including those completed from suggestions but not including those that end
up being searches in the search engine.
</summary>
</rappor-metric>
<rappor-metric name="PowerfulFeatureUse.Host.ApplicationCacheAPI.Insecure"
type="ETLD_PLUS_ONE">
<owner>jww@chromium.org</owner>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment