Commit d59812d2 authored by Ken Rockot's avatar Ken Rockot Committed by Commit Bot

Mojo: Fix possible null dereference

There is a branch of Node::OnUserMessageReadAckRequest where the local
`event_to_send` is never initialized from a null state. It is however
unconditionally passed to `ForwardEvent` which assumes a non-null
object.

Bug: None
Change-Id: I3615c02033f58412f2322c7a6df6bad20ab451a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485847Reviewed-by: default avatarOksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#818680}
parent 98e68d6b
...@@ -920,7 +920,8 @@ int Node::OnUserMessageReadAckRequest( ...@@ -920,7 +920,8 @@ int Node::OnUserMessageReadAckRequest(
} }
} }
delegate_->ForwardEvent(peer_node_name, std::move(event_to_send)); if (event_to_send)
delegate_->ForwardEvent(peer_node_name, std::move(event_to_send));
return OK; return OK;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment