Commit d5a15fde authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Revert "bindings: Disable V8 context snapshot feature on cross compile environment"

This reverts commit 714aff4e.

Reason for revert: Revert to see if "WebKit Linux Trusty MSAN" creates a v8_context_snapshot.bin again.

Original change's description:
> bindings: Disable V8 context snapshot feature on cross compile environment
> 
> This change can disable the feature on some environments which are
> going well, but this is a simple fix to fix the build error on
> "32-bit ASAN V8 ARM Builders" bots.
> 
> 
> Bug: 760120
> Change-Id: I09dc29b61118409baf7f7b538ce376574df175be
> Reviewed-on: https://chromium-review.googlesource.com/662962
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501533}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org
NOTRY=true

Change-Id: I613de5108c3a64b24c20f4c16349ab5aeeca8cc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 760120
Reviewed-on: https://chromium-review.googlesource.com/665137Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501618}
parent 0128b769
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
import("//build/config/c++/c++.gni") import("//build/config/c++/c++.gni")
import("//build/config/chromecast_build.gni") import("//build/config/chromecast_build.gni")
import("//build/config/compiler/compiler.gni") import("//build/config/compiler/compiler.gni")
import("//build/config/v8_target_cpu.gni")
import("//v8/snapshot_toolchain.gni") import("//v8/snapshot_toolchain.gni")
if (is_android) { if (is_android) {
...@@ -18,9 +17,7 @@ if (is_android) { ...@@ -18,9 +17,7 @@ if (is_android) {
} }
declare_args() { declare_args() {
# TODO(crbug.com/764576): Enable the feature on more environments. use_v8_context_snapshot = !is_chromeos && !is_android && !is_chromecast
use_v8_context_snapshot = !is_chromeos && !is_android && !is_chromecast &&
v8_target_cpu == target_cpu
} }
if (is_android) { if (is_android) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment