Commit d5bcbd33 authored by Scott Lee's avatar Scott Lee Committed by Chromium LUCI CQ

[resultdb] fully enable resultdb for junit tests on CI builders

Steps with junit_tests and resultdb ran successfully 3368 times,
but one failed. The failure was from the test itself.

https://screenshot.googleplex.com/AmZp5peQzJrzz3c
https://ci.chromium.org/p/chromium/builders/ci/Android%20arm%20Builder%20(dbg)/53534

R=gbeaty@chromium.org
CC=chanli@chromium.org,nodir@chromium.org

Bug: 1084332
Change-Id: I416787631a029491b758be2b5df17a4ffb59b41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589640Reviewed-by: default avatarGarrett Beaty <gbeaty@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836698}
parent 6f040f88
This source diff could not be displayed because it is too large. You can view the blob instead.
...@@ -420,6 +420,7 @@ def ci_builder( ...@@ -420,6 +420,7 @@ def ci_builder(
# Enable "chromium.resultdb.result_sink" on ci builders. # Enable "chromium.resultdb.result_sink" on ci builders.
experiments = experiments or {} experiments = experiments or {}
experiments.setdefault("chromium.resultdb.result_sink", 100) experiments.setdefault("chromium.resultdb.result_sink", 100)
experiments.setdefault("chromium.resultdb.result_sink.junit_tests", 100)
# Define the builder first so that any validation of luci.builder arguments # Define the builder first so that any validation of luci.builder arguments
# (e.g. bucket) occurs before we try to use it # (e.g. bucket) occurs before we try to use it
...@@ -506,9 +507,6 @@ def android_builder( ...@@ -506,9 +507,6 @@ def android_builder(
builder_group = "chromium.android", builder_group = "chromium.android",
goma_backend = builders.goma.backend.RBE_PROD, goma_backend = builders.goma.backend.RBE_PROD,
goma_jobs = goma_jobs, goma_jobs = goma_jobs,
experiments = {
"chromium.resultdb.result_sink.junit_tests": 50,
},
**kwargs **kwargs
) )
...@@ -553,9 +551,6 @@ def clang_builder(*, name, builderless = True, cores = 32, properties = None, ** ...@@ -553,9 +551,6 @@ def clang_builder(*, name, builderless = True, cores = 32, properties = None, **
# CFI builds will take even longer - around 11h. # CFI builds will take even longer - around 11h.
execution_timeout = 14 * time.hour, execution_timeout = 14 * time.hour,
properties = properties, properties = properties,
experiments = {
"chromium.resultdb.result_sink.junit_tests": 50,
},
**kwargs **kwargs
) )
...@@ -658,12 +653,6 @@ def fyi_builder( ...@@ -658,12 +653,6 @@ def fyi_builder(
builder_group = "chromium.fyi", builder_group = "chromium.fyi",
execution_timeout = execution_timeout, execution_timeout = execution_timeout,
goma_backend = goma_backend, goma_backend = goma_backend,
# TODO(crbug.com/1108016): Move this kwarg to ci.builder(), after
# ResultSink and result_adapter is confirmed to work.
experiments = {
"chromium.resultdb.result_sink": 100,
"chromium.resultdb.result_sink.junit_tests": 30,
},
**kwargs **kwargs
) )
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment