Commit d5e2a2c8 authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

CodeGen: Add header guard in generated header files


Bug: 839389
Change-Id: I96e9719daf91ebb84a57e05e9982b4c2cfd345e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972734Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726663}
parent 16e15d0b
...@@ -25,6 +25,7 @@ from .codegen_context import CodeGenContext ...@@ -25,6 +25,7 @@ from .codegen_context import CodeGenContext
from .codegen_expr import expr_from_exposure from .codegen_expr import expr_from_exposure
from .codegen_format import format_template as _format from .codegen_format import format_template as _format
from .codegen_utils import collect_include_headers from .codegen_utils import collect_include_headers
from .codegen_utils import enclose_with_header_guard
from .codegen_utils import enclose_with_namespace from .codegen_utils import enclose_with_namespace
from .codegen_utils import make_copyright_header from .codegen_utils import make_copyright_header
from .codegen_utils import make_forward_declarations from .codegen_utils import make_forward_declarations
...@@ -703,17 +704,26 @@ def generate_dictionary_h_file(dictionary): ...@@ -703,17 +704,26 @@ def generate_dictionary_h_file(dictionary):
"Visitor", "Visitor",
]) ])
namespace_node = enclose_with_namespace(
ListNode([
make_forward_declarations(root_node.accumulator),
TextNode(""),
code_node,
]), name_style.namespace("blink"))
header_guard = name_style.header_guard(
PathManager(dictionary).dict_path(ext="h"))
header_guard_node = enclose_with_header_guard(
ListNode([
make_header_include_directives(root_node.accumulator),
TextNode(""),
namespace_node,
]), header_guard)
root_node.extend([ root_node.extend([
make_copyright_header(), make_copyright_header(),
TextNode(""), TextNode(""),
make_header_include_directives(root_node.accumulator), header_guard_node,
TextNode(""),
enclose_with_namespace(
ListNode([
make_forward_declarations(root_node.accumulator),
TextNode(""),
code_node,
]), name_style.namespace("blink")),
]) ])
filename = "example_dictionary.h" filename = "example_dictionary.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment