Revert "Use attached browser CreateParams in CreateBrowserForDrag"
This reverts commit 5a45cc91. Reason for revert: crbug.com/1015534 suspects performance regression. It is hard to interpret the results in that bug, so I will revert and rerun perf analysis. I suspect this change made no difference, and if that is confirmed, I will reland. Original change's description: > Use attached browser CreateParams in CreateBrowserForDrag > > Use the attached browser CreateParams rather than > BrowserList GetLastActive. > > It feels safer that the attached browser will always > be the one that we want whereas BrowserList GetLastActive > may not be so reliable. > > Bug: 1012169 > Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706220} TBR=pkasting@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015534 Bug: 1012169 Change-Id: Ief9fa8770467e12c14a3b86b6c004a0b6d2b62cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882202Reviewed-by:Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709793}
Showing
Please register or sign in to comment