Commit d617d6c4 authored by Ben Wagner aka dogben's avatar Ben Wagner aka dogben Committed by Chromium LUCI CQ

Revert "Mark some WebRTC perf measurements as biggerIsBetter"

This reverts commit 9c270678.

Reason for revert: mbonadei noticed error when running

Original change's description:
> Mark some WebRTC perf measurements as biggerIsBetter
>
> Change-Id: I95a145f0380b0f413a71ef5a9bbacf840eb20b9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577205
> Commit-Queue: John Chen <johnchen@chromium.org>
> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#834889}

TBR=mbonadei@chromium.org,johnchen@chromium.org,benjaminwagner@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I4f90ecb003407c3737442f0a5d4ca691c4d12dbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580527Reviewed-by: default avatarMirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Cr-Commit-Position: refs/heads/master@{#835135}
parent 90bb5ddd
......@@ -48,7 +48,7 @@ class DataChannel(WebrtcPage):
def ParseTestResults(self, action_runner):
self.AddJavaScriptMeasurement(
'data_transferred',
'bytes_biggerIsBetter',
'bytes',
'receiveProgress.value',
description='Amount of data transferred by data channel in 10 seconds')
......@@ -155,7 +155,7 @@ class InsertableStreamsVideoProcessing(WebrtcPage):
def ExecuteTest(self, action_runner):
self.AddMeasurement(
'supported', 'count_biggerIsBetter', 1 if self.supported else 0,
'supported', 'count', 1 if self.supported else 0,
'Boolean flag indicating if this benchmark is supported by the browser.'
)
if not self.supported:
......@@ -178,7 +178,7 @@ class InsertableStreamsVideoProcessing(WebrtcPage):
action_runner.Wait(10)
self.AddJavaScriptMeasurement(
'sink_decoded_frames',
'count_biggerIsBetter',
'count',
'document.querySelector(".sinkVideo").webkitDecodedFrameCount',
description='Number of frames received at the sink video.')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment