Commit d6300bd0 authored by vadimt's avatar vadimt Committed by Commit bot

Revert of Instrumenting opening password database to find jank (patchset #1...

Revert of Instrumenting opening password database to find jank (patchset #1 id:1 of https://codereview.chromium.org/807263003/)

Reason for revert:
Undoing profiler instrumentations since the jank is fixed.

Original issue's description:
> Instrumenting opening password database to find jank.
>
> This database opening happens in UI thread. Checking what jankiness this causes.
>
> Background: one of jankiness investigations (crbug.com/426272) came to a conclusion that the jank is actually caused by this issue. Instrumenting to get the numbers.
>
> BUG=138903
>
> Committed: https://crrev.com/42466460ec1a5c0f2953d13e57d0d290cb38ca21
> Cr-Commit-Position: refs/heads/master@{#308702}

TBR=isherman@chromium.org
BUG=138903

Review URL: https://codereview.chromium.org/878763002

Cr-Commit-Position: refs/heads/master@{#313168}
parent c493d268
...@@ -12,7 +12,6 @@ ...@@ -12,7 +12,6 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "base/pickle.h" #include "base/pickle.h"
#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_util.h" #include "base/strings/string_util.h"
#include "base/strings/stringprintf.h" #include "base/strings/stringprintf.h"
#include "base/time/time.h" #include "base/time/time.h"
...@@ -167,15 +166,9 @@ bool LoginDatabase::Init() { ...@@ -167,15 +166,9 @@ bool LoginDatabase::Init() {
db_.set_exclusive_locking(); db_.set_exclusive_locking();
db_.set_restrict_to_user(); db_.set_restrict_to_user();
{ if (!db_.Open(db_path_)) {
// TODO(vadimt): Remove ScopedTracker below once crbug.com/138903 is fixed. LOG(WARNING) << "Unable to open the password store database.";
tracked_objects::ScopedTracker tracking_profile( return false;
FROM_HERE_WITH_EXPLICIT_FUNCTION("138903 LoginDatabase::Init db init"));
if (!db_.Open(db_path_)) {
LOG(WARNING) << "Unable to open the password store database.";
return false;
}
} }
sql::Transaction transaction(&db_); sql::Transaction transaction(&db_);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment