Commit d63b7fcb authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

Revert "Optimize for speed Android performance sensitive functions."

This reverts commit 9d395e1d.

Reason for revert: Finished collecting data.

Original change's description:
> Optimize for speed Android performance sensitive functions.
>
> Set optimize_max compiler options to build some hot blink render
> components and improve size-vs-speed balance on Android.
>
> Pixel4 Aarch32/64:
> +628Kb/+884Kb libchrome size
> +6.9%/+5.7% speedometer2 speed
>
> Bug: 1125115
>
> Binary-Size: Will revert this after perf graphs show impact of it.
> Change-Id: I45e176ae1cbc2e513eda986b667ce65640ec9a2a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390778
> Commit-Queue: Pavel Iliin <Pavel.Iliin@arm.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804555}

TBR=agrieve@chromium.org,Pavel.Iliin@arm.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1125115
Change-Id: I66387878027a71a59a65b269b6e95b3b31c5d90a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436271Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811443}
parent 79963ce7
......@@ -276,11 +276,6 @@ blink_core_sources("animation") {
"worklet_animation_controller.h",
]
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
deps = [ ":buildflags" ]
}
......
......@@ -594,10 +594,6 @@ blink_core_sources("css") {
"vision_deficiency.h",
"zoom_adjusted_pixel_value.h",
]
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
}
blink_core_tests("unit_tests") {
......
......@@ -309,13 +309,6 @@ blink_core_sources("dom") {
"xml_document.h",
]
# TODO(pavel.iliin) hot path functions separtion into "dom_hotpath" is not
# required anymore. Combine them with "dom" sources.
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
public_deps = [
"//third_party/blink/public/mojom:mojom_core_blink",
......
......@@ -223,11 +223,6 @@ blink_core_sources("frame") {
"window_or_worker_global_scope.h",
]
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
deps = [
"//printing/buildflags",
"//skia",
......
......@@ -598,11 +598,6 @@ blink_core_sources("html") {
"window_name_collection.h",
]
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
deps = [
"//services/metrics/public/cpp:metrics_cpp",
"//skia:skcms",
......
......@@ -657,11 +657,6 @@ blink_core_sources("layout") {
]
}
if (is_android && !is_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
if (is_fuchsia) {
sources += [ "layout_theme_fuchsia.cc" ]
}
......
......@@ -263,8 +263,4 @@ blink_core_sources("paint") {
"view_painter.cc",
"view_painter.h",
]
if (!is_debug && is_android) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
}
......@@ -114,7 +114,7 @@ blink_platform_sources("heap") {
"//v8",
]
if (!is_debug && (!optimize_for_size || is_android)) {
if (!is_debug && !optimize_for_size) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
......
......@@ -252,7 +252,7 @@ component("wtf") {
sources -= [ "text/atomic_string_cf.cc" ]
}
if (!is_debug && (!optimize_for_size || is_android)) {
if (!is_debug && !optimize_for_size) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment