Commit d6413e36 authored by Peter Beverloo's avatar Peter Beverloo Committed by Commit Bot

Enable native notifications for Windows by default

Bug: 819675, 734095
Change-Id: I9c9ff697d45118c220992b87ccbffe40ffa0bef5
Reviewed-on: https://chromium-review.googlesource.com/1185187Reviewed-by: default avatarXi Cheng <chengx@chromium.org>
Reviewed-by: default avatarFinnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585257}
parent d714188a
...@@ -46,15 +46,11 @@ namespace { ...@@ -46,15 +46,11 @@ namespace {
// * Android // * Android
// Always uses native notifications. // Always uses native notifications.
// //
// * Mac OS X, Linux // * Mac OS X, Linux, Windows 10 RS1+
// Uses native notifications by default, but can fall back to the message // Uses native notifications by default, but can fall back to the message
// center if base::kNativeNotifications is disabled or initialization fails. // center if base::kNativeNotifications is disabled or initialization fails.
// //
// * Windows 10 RS1+: // * Chrome OS
// Uses the message center by default, but can use native notifications if
// base::kNativeNotifications is enabled or initialization fails.
//
// * Chrome OS:
// Always uses the message center, either through the message center // Always uses the message center, either through the message center
// notification platform bridge when base::kNativeNotifications is disabled, // notification platform bridge when base::kNativeNotifications is disabled,
// which means the message center runs in-process, or through the Chrome OS // which means the message center runs in-process, or through the Chrome OS
......
...@@ -387,13 +387,8 @@ const base::Feature kModalPermissionPrompts{"ModalPermissionPrompts", ...@@ -387,13 +387,8 @@ const base::Feature kModalPermissionPrompts{"ModalPermissionPrompts",
// Center for displaying the toasts. The feature is hardcoded to enabled for // Center for displaying the toasts. The feature is hardcoded to enabled for
// Chrome OS. // Chrome OS.
#if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS) && !defined(OS_CHROMEOS) #if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS) && !defined(OS_CHROMEOS)
#if defined(OS_MACOSX) || defined(OS_ANDROID) || defined(OS_LINUX)
const base::Feature kNativeNotifications{"NativeNotifications", const base::Feature kNativeNotifications{"NativeNotifications",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
#else
const base::Feature kNativeNotifications{"NativeNotifications",
base::FEATURE_DISABLED_BY_DEFAULT};
#endif
#endif // BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS) #endif // BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
const base::Feature kNetworkPrediction{"NetworkPrediction", const base::Feature kNetworkPrediction{"NetworkPrediction",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment