Commit d6466202 authored by Stephen McGruer's avatar Stephen McGruer Committed by Commit Bot

[Sheriff] Mark FeedAppLifecycleTest tests as flaky

These tests are failing flaky with crashes.

TBR=pnoland@chromium.org

Bug: 891419
Change-Id: I99d699e29e3be1f0d167531fe702011bbf2c3c9e
Reviewed-on: https://chromium-review.googlesource.com/c/1259422
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: default avatarStephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596320}
parent 59048c8c
...@@ -29,6 +29,7 @@ import org.chromium.base.metrics.RecordHistogram; ...@@ -29,6 +29,7 @@ import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.CallbackHelper; import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags; import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature; import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.chrome.browser.ChromeFeatureList; import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.ChromeSwitches; import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ChromeTabbedActivity; import org.chromium.chrome.browser.ChromeTabbedActivity;
...@@ -87,6 +88,7 @@ public class FeedAppLifecycleTest { ...@@ -87,6 +88,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void construction_checks_active_tabbed_activities() { public void construction_checks_active_tabbed_activities() {
verify(mAppLifecycleListener, times(1)).onEnterForeground(); verify(mAppLifecycleListener, times(1)).onEnterForeground();
} }
...@@ -94,6 +96,7 @@ public class FeedAppLifecycleTest { ...@@ -94,6 +96,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void activity_state_changes_increment_state_counters() public void activity_state_changes_increment_state_counters()
throws InterruptedException, TimeoutException { throws InterruptedException, TimeoutException {
assertEquals(0, assertEquals(0,
...@@ -119,6 +122,7 @@ public class FeedAppLifecycleTest { ...@@ -119,6 +122,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void ntp_opening_triggers_initialize_only_once() throws InterruptedException { public void ntp_opening_triggers_initialize_only_once() throws InterruptedException {
// We open to about:blank initially so we shouldn't have called initialize() yet. // We open to about:blank initially so we shouldn't have called initialize() yet.
verify(mAppLifecycleListener, times(0)).initialize(); verify(mAppLifecycleListener, times(0)).initialize();
...@@ -137,6 +141,7 @@ public class FeedAppLifecycleTest { ...@@ -137,6 +141,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void history_deletion_triggers_clear_all() throws InterruptedException { public void history_deletion_triggers_clear_all() throws InterruptedException {
verify(mAppLifecycleListener, times(0)).onClearAll(); verify(mAppLifecycleListener, times(0)).onClearAll();
mAppLifecycle.onHistoryDeleted(); mAppLifecycle.onHistoryDeleted();
...@@ -149,6 +154,7 @@ public class FeedAppLifecycleTest { ...@@ -149,6 +154,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void cached_data_removal_triggers_clear_all() throws InterruptedException { public void cached_data_removal_triggers_clear_all() throws InterruptedException {
verify(mAppLifecycleListener, times(0)).onClearAll(); verify(mAppLifecycleListener, times(0)).onClearAll();
mAppLifecycle.onCachedDataCleared(); mAppLifecycle.onCachedDataCleared();
...@@ -161,6 +167,7 @@ public class FeedAppLifecycleTest { ...@@ -161,6 +167,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void signout_triggers_clear_all() throws InterruptedException { public void signout_triggers_clear_all() throws InterruptedException {
verify(mAppLifecycleListener, times(0)).onClearAll(); verify(mAppLifecycleListener, times(0)).onClearAll();
mAppLifecycle.onSignedOut(); mAppLifecycle.onSignedOut();
...@@ -173,6 +180,7 @@ public class FeedAppLifecycleTest { ...@@ -173,6 +180,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void signin_triggers_clear_all() throws InterruptedException { public void signin_triggers_clear_all() throws InterruptedException {
verify(mAppLifecycleListener, times(0)).onClearAll(); verify(mAppLifecycleListener, times(0)).onClearAll();
mAppLifecycle.onSignedIn(); mAppLifecycle.onSignedIn();
...@@ -185,6 +193,7 @@ public class FeedAppLifecycleTest { ...@@ -185,6 +193,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void second_window_does_not_trigger_foreground_or_background() public void second_window_does_not_trigger_foreground_or_background()
throws InterruptedException, TimeoutException { throws InterruptedException, TimeoutException {
verify(mAppLifecycleListener, times(1)).onEnterForeground(); verify(mAppLifecycleListener, times(1)).onEnterForeground();
...@@ -210,6 +219,7 @@ public class FeedAppLifecycleTest { ...@@ -210,6 +219,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void multi_window_does_not_cause_multiple_initialize() throws InterruptedException { public void multi_window_does_not_cause_multiple_initialize() throws InterruptedException {
mActivityTestRule.loadUrl(UrlConstants.NTP_URL); mActivityTestRule.loadUrl(UrlConstants.NTP_URL);
verify(mAppLifecycleListener, times(1)).initialize(); verify(mAppLifecycleListener, times(1)).initialize();
...@@ -224,6 +234,7 @@ public class FeedAppLifecycleTest { ...@@ -224,6 +234,7 @@ public class FeedAppLifecycleTest {
@Test @Test
@SmallTest @SmallTest
@Feature({"InterestFeedContentSuggestions"}) @Feature({"InterestFeedContentSuggestions"})
@FlakyTest(message = "http://crbug.com/891419")
public void resume_triggers_scheduler_foregrounded() public void resume_triggers_scheduler_foregrounded()
throws InterruptedException, TimeoutException { throws InterruptedException, TimeoutException {
// Starting mActivity in setUp() triggers a resume. // Starting mActivity in setUp() triggers a resume.
...@@ -260,4 +271,4 @@ public class FeedAppLifecycleTest { ...@@ -260,4 +271,4 @@ public class FeedAppLifecycleTest {
waitForStateChangeHelper.waitForCallback(0); waitForStateChangeHelper.waitForCallback(0);
} }
} }
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment