Download later: Make "don't show again" checkbox uncheck by default.

This CL makes the "don't show again" checkbox by default unchecked.
This is discussed with PM that the 3+1 approach may be confusing to the
user, and we don't want a IPH on the download later dialog.

Bug: 1117573
Change-Id: I23a95720d031489a4a5ccfa4ec872e9e613279a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423044
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809445}

chrome/android/javatests/src/org/chromium/chrome/browser/download/dialogs/DownloadLaterDialogTest.java

@@ -168,7 +168,7 @@ public class DownloadLaterDialogTest {
                 DownloadLaterDialogChoice.ON_WIFI, DownloadLaterPromptStatus.SHOW_INITIAL);
         showDialog();
         assertPositiveButtonText("Download");
-        assertShowAgainCheckBox(true, View.VISIBLE, true);
+        assertShowAgainCheckBox(true, View.VISIBLE, false);
         assertEditText(false);
     }
 
@@ -191,7 +191,7 @@ public class DownloadLaterDialogTest {
                 DownloadLaterDialogChoice.DOWNLOAD_LATER, DownloadLaterPromptStatus.SHOW_INITIAL);
         showDialog();
         assertPositiveButtonText("Next");
-        assertShowAgainCheckBox(false, View.VISIBLE, true);
+        assertShowAgainCheckBox(false, View.VISIBLE, false);
         assertEditText(false);
     }
 
@@ -245,7 +245,7 @@ public class DownloadLaterDialogTest {
         });
 
         assertPositiveButtonText("Next");
-        assertShowAgainCheckBox(false, View.VISIBLE, true);
+        assertShowAgainCheckBox(false, View.VISIBLE, false);
 
         clickPositiveButton();
         verify(mController, times(0)).onDownloadLaterDialogComplete(anyInt(), anyLong());

chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLaterDialogView.java

@@ -119,10 +119,8 @@ public class DownloadLaterDialogView extends ScrollView implements OnCheckedChan
     }
 
     void setCheckbox(@DownloadLaterPromptStatus int promptStatus) {
-        boolean checked = (promptStatus == DownloadLaterPromptStatus.SHOW_INITIAL)
-                || (promptStatus == DownloadLaterPromptStatus.DONT_SHOW);
         mCheckBox.setVisibility(VISIBLE);
-        mCheckBox.setChecked(checked);
+        mCheckBox.setChecked(promptStatus == DownloadLaterPromptStatus.DONT_SHOW);
     }
 
     void setCheckboxEnabled(boolean enabled) {