ash: Enable notification in OOBE to display system notification.

BUG=1093614

Change-Id: Ie5a368ff723970b10527d9249f6bc490d7ba1b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261852Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782698}

ash/system/message_center/session_state_notification_blocker.cc

@@ -26,6 +26,10 @@ bool CalculateShouldShowPopup() {
   SessionControllerImpl* const session_controller =
       Shell::Get()->session_controller();
 
+  // Enable popup in OOBE to display system notifications (wifi, etc.).
+  if (session_controller->GetSessionState() == SessionState::OOBE)
+    return true;
+
   if (session_controller->IsRunningInAppMode() ||
       session_controller->GetSessionState() != SessionState::ACTIVE) {
     return false;

ash/system/message_center/session_state_notification_blocker_unittest.cc

@@ -81,14 +81,16 @@ class SessionStateNotificationBlockerTest
 };
 
 TEST_F(SessionStateNotificationBlockerTest, BaseTest) {
-  // Default status: OOBE.
+  // OOBE.
+  GetSessionControllerClient()->SetSessionState(SessionState::OOBE);
+  EXPECT_EQ(1, GetStateChangedCountAndReset());
   message_center::NotifierId notifier_id(
       message_center::NotifierType::APPLICATION, "test-notifier");
-  EXPECT_FALSE(ShouldShowNotificationAsPopup(notifier_id));
+  EXPECT_TRUE(ShouldShowNotificationAsPopup(notifier_id));
 
   // Login screen.
   GetSessionControllerClient()->SetSessionState(SessionState::LOGIN_PRIMARY);
-  EXPECT_EQ(0, GetStateChangedCountAndReset());
+  EXPECT_EQ(1, GetStateChangedCountAndReset());
   EXPECT_FALSE(ShouldShowNotificationAsPopup(notifier_id));
 
   // Logged in as a normal user.
@@ -112,12 +114,14 @@ TEST_F(SessionStateNotificationBlockerTest, AlwaysAllowedNotifier) {
   message_center::NotifierId notifier_id(
       message_center::NotifierType::SYSTEM_COMPONENT, kNotifierSystemPriority);
 
-  // Default status: OOBE.
+  // OOBE.
+  GetSessionControllerClient()->SetSessionState(SessionState::OOBE);
+  EXPECT_EQ(1, GetStateChangedCountAndReset());
   EXPECT_TRUE(ShouldShowNotificationAsPopup(notifier_id));
 
   // Login screen.
   GetSessionControllerClient()->SetSessionState(SessionState::LOGIN_PRIMARY);
-  EXPECT_EQ(0, GetStateChangedCountAndReset());
+  EXPECT_EQ(1, GetStateChangedCountAndReset());
   EXPECT_TRUE(ShouldShowNotificationAsPopup(notifier_id));
 
   // Logged in as a normal user.
@@ -137,14 +141,16 @@ TEST_F(SessionStateNotificationBlockerTest, AlwaysAllowedNotifier) {
 }
 
 TEST_F(SessionStateNotificationBlockerTest, BlockOnPrefService) {
-  // Default status: OOBE.
+  // OOBE.
+  GetSessionControllerClient()->SetSessionState(SessionState::OOBE);
+  EXPECT_EQ(1, GetStateChangedCountAndReset());
   message_center::NotifierId notifier_id(
       message_center::NotifierType::APPLICATION, "test-notifier");
-  EXPECT_FALSE(ShouldShowNotificationAsPopup(notifier_id));
+  EXPECT_TRUE(ShouldShowNotificationAsPopup(notifier_id));
 
   // Login screen.
   GetSessionControllerClient()->SetSessionState(SessionState::LOGIN_PRIMARY);
-  EXPECT_EQ(0, GetStateChangedCountAndReset());
+  EXPECT_EQ(1, GetStateChangedCountAndReset());
   EXPECT_FALSE(ShouldShowNotificationAsPopup(notifier_id));
 
   // Simulates login event sequence in production code: