Commit d665ffc9 authored by Tom Anderson's avatar Tom Anderson Committed by Commit Bot

Remove some debug logging in browser_main_loop.cc

Clusterfuzz has marked bug 821704 as fixed, though it's possible adding the
logging perturbed the timing just right so that this bug is no longer triggered.
Or the bug may actually be fixed.  Either way, we should remove the logging to
make sure the bug doesn't resurface.

Bug: 821704
Change-Id: I4fb5a1394162e814ef28b2a5834af2bc13304ce0
R: gab
Reviewed-on: https://chromium-review.googlesource.com/1117304Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570876}
parent 5796dc83
...@@ -16,7 +16,6 @@ ...@@ -16,7 +16,6 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/debug/alias.h" #include "base/debug/alias.h"
#include "base/debug/stack_trace.h"
#include "base/deferred_sequenced_task_runner.h" #include "base/deferred_sequenced_task_runner.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/location.h" #include "base/location.h"
...@@ -260,12 +259,6 @@ static void GLibLogHandler(const gchar* log_domain, ...@@ -260,12 +259,6 @@ static void GLibLogHandler(const gchar* log_domain,
if ((always_fatal_flags | fatal_flags) & log_level) { if ((always_fatal_flags | fatal_flags) & log_level) {
LOG(DFATAL) << log_domain << ": " << message; LOG(DFATAL) << log_domain << ": " << message;
} else if (log_level & (G_LOG_LEVEL_ERROR | G_LOG_LEVEL_CRITICAL)) { } else if (log_level & (G_LOG_LEVEL_ERROR | G_LOG_LEVEL_CRITICAL)) {
#if defined(THREAD_SANITIZER)
// TODO(thomasanderson): This is temporary debugging for
// https://crbug.com/821704. Revert this CL once we have the stack trace:
// https://chromium-review.googlesource.com/#/c/chromium/src/+/1069247
base::debug::StackTrace().Print();
#endif
LOG(ERROR) << log_domain << ": " << message; LOG(ERROR) << log_domain << ": " << message;
} else if (log_level & (G_LOG_LEVEL_WARNING)) { } else if (log_level & (G_LOG_LEVEL_WARNING)) {
LOG(WARNING) << log_domain << ": " << message; LOG(WARNING) << log_domain << ": " << message;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment