Commit d67a4435 authored by Alexei Svitkine's avatar Alexei Svitkine Committed by Commit Bot

Clean up Arc.OOMKills histogram allowlist entry.

As mentioned on the referenced bug, these are no longer logged.

Bug: None
Change-Id: If52c473b89dddf3fb60e16b86cbd3caa70c949b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462224
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816791}
parent 2c406273
......@@ -454,13 +454,10 @@ bool Histogram::InspectConstructionArguments(StringPiece name,
UmaHistogramSparse("Histogram.TooManyBuckets.1000",
static_cast<Sample>(HashMetricName(name)));
// TODO(bcwhite): Clean these up as bugs get fixed. Also look at injecting
// whitelist (using hashes) from a higher layer rather than hardcoding
// them here.
// TODO(bcwhite): Look at injecting allowlist (using hashes) from a higher
// layer rather than hardcoding them here.
// Blink.UseCounter legitimately has more than 1000 entries in its enum.
// Arc.OOMKills: https://crbug.com/916757
if (!StartsWith(name, "Blink.UseCounter") &&
!StartsWith(name, "Arc.OOMKills.")) {
if (!StartsWith(name, "Blink.UseCounter")) {
DVLOG(1) << "Histogram: " << name
<< " has bad bucket_count: " << *bucket_count << " (limit "
<< kBucketCount_MAX << ")";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment