weblayer: const& -> *

This is necessitated by Navigation not having const functions. It would be
nice for Navigation to have const functions, but that isn't possible because
we generally don't have const functions in content.

BUG=none
TEST=none

Change-Id: I57f7385730e0eca623d8762512fff8403699c779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779002Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692175}

weblayer/browser/navigation_controller_impl.cc

@@ -85,7 +85,7 @@ void NavigationControllerImpl::DidStartNavigation(
       std::make_unique<NavigationImpl>(navigation_handle);
   auto* navigation = navigation_map_[navigation_handle].get();
   for (auto& observer : observers_)
-    observer.NavigationStarted(*navigation);
+    observer.NavigationStarted(navigation);
 }
 
 void NavigationControllerImpl::DidRedirectNavigation(
@@ -96,7 +96,7 @@ void NavigationControllerImpl::DidRedirectNavigation(
   DCHECK(navigation_map_.find(navigation_handle) != navigation_map_.end());
   auto* navigation = navigation_map_[navigation_handle].get();
   for (auto& observer : observers_)
-    observer.NavigationRedirected(*navigation);
+    observer.NavigationRedirected(navigation);
 }
 
 void NavigationControllerImpl::ReadyToCommitNavigation(
@@ -107,7 +107,7 @@ void NavigationControllerImpl::ReadyToCommitNavigation(
   DCHECK(navigation_map_.find(navigation_handle) != navigation_map_.end());
   auto* navigation = navigation_map_[navigation_handle].get();
   for (auto& observer : observers_)
-    observer.NavigationCommitted(*navigation);
+    observer.NavigationCommitted(navigation);
 }
 
 void NavigationControllerImpl::DidFinishNavigation(
@@ -120,10 +120,10 @@ void NavigationControllerImpl::DidFinishNavigation(
   if (navigation_handle->GetNetErrorCode() == net::OK &&
       !navigation_handle->IsErrorPage()) {
     for (auto& observer : observers_)
-      observer.NavigationCompleted(*navigation);
+      observer.NavigationCompleted(navigation);
   } else {
     for (auto& observer : observers_)
-      observer.NavigationFailed(*navigation);
+      observer.NavigationFailed(navigation);
   }
 
   navigation_map_.erase(navigation_map_.find(navigation_handle));

weblayer/public/navigation_observer.h

@@ -20,15 +20,15 @@ class NavigationObserver {
  public:
   virtual ~NavigationObserver() {}
 
-  virtual void NavigationStarted(const Navigation& navigation) {}
+  virtual void NavigationStarted(Navigation* navigation) {}
 
-  virtual void NavigationRedirected(const Navigation& navigation) {}
+  virtual void NavigationRedirected(Navigation* navigation) {}
 
-  virtual void NavigationCommitted(const Navigation& navigation) {}
+  virtual void NavigationCommitted(Navigation* navigation) {}
 
-  virtual void NavigationCompleted(const Navigation& navigation) {}
+  virtual void NavigationCompleted(Navigation* navigation) {}
 
-  virtual void NavigationFailed(const Navigation& navigation) {}
+  virtual void NavigationFailed(Navigation* navigation) {}
 };
 
 }  // namespace weblayer