Skip to content

GitLab

T
tangled
Commit d69ae10a authored by Luciano Pacheco's avatar Luciano Pacheco Committed by Chromium LUCI CQ
Browse files
Options

Files app: Add the optimize_webui() rule for foreground page 

This is a preparation to run the foreground page as JS modules.

Bug: 1133186
Change-Id: Iad424b0d91985015bc1cf746866c996c3334fe88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637167
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Reviewed-by: default avatarJeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844998}
parent bc1a8d3d
Hide whitespace changes
Inline Side-by-side
Showing with 48 additions and 1 deletion
ui/file_manager/BUILD.gn
View file @ d69ae10a
......@@ -85,6 +85,7 @@ preprocess_if_expr("preprocess_static") {
"audio_player/js/main.m.js",
"audio_player/js/main_background.m.js",
"file_manager/background/js/main_background.m.js",
"file_manager/foreground/js/deferred_elements.m.js",
"file_manager/foreground/js/elements_importer.m.js",
"file_manager/foreground/js/main.m.js",
"image_loader/background.m.js",
......@@ -96,6 +97,7 @@ preprocess_if_expr("preprocess_static") {
"//ui/file_manager/audio_player/js:main.m",
"//ui/file_manager/audio_player/js:main_background.m",
"//ui/file_manager/file_manager/background/js:main_background.m",
"//ui/file_manager/file_manager/foreground/js:deferred_elements.m",
"//ui/file_manager/file_manager/foreground/js:main.m",
"//ui/file_manager/image_loader:background.m",
"//ui/file_manager/video_player/js:main.m",
......@@ -232,6 +234,7 @@ preprocess_if_expr("preprocess_generated") {
"file_manager/foreground/js/main_window_component.m.js",
"file_manager/foreground/js/metadata_box_controller.m.js",
"file_manager/foreground/js/metadata_update_controller.m.js",
"file_manager/foreground/js/metrics_start.m.js",
"file_manager/foreground/js/naming_controller.m.js",
"file_manager/foreground/js/navigation_list_model.m.js",
"file_manager/foreground/js/navigation_uma.m.js",
......@@ -254,6 +257,7 @@ preprocess_if_expr("preprocess_generated") {
# Files app Elements:
"file_manager/foreground/elements/icons.m.js",
"file_manager/foreground/elements/files_format_dialog.m.js",
"file_manager/foreground/elements/files_icon_button.m.js",
"file_manager/foreground/elements/files_message.m.js",
"file_manager/foreground/elements/files_metadata_box.m.js",
......@@ -262,9 +266,14 @@ preprocess_if_expr("preprocess_generated") {
"file_manager/foreground/elements/files_quick_view.m.js",
"file_manager/foreground/elements/files_ripple.m.js",
"file_manager/foreground/elements/files_safe_media.m.js",
"file_manager/foreground/elements/files_spinner.m.js",
"file_manager/foreground/elements/files_toast.m.js",
"file_manager/foreground/elements/files_toggle_ripple.m.js",
"file_manager/foreground/elements/files_tooltip.m.js",
"file_manager/foreground/elements/xf_button.m.js",
"file_manager/foreground/elements/xf_circular_progress.m.js",
"file_manager/foreground/elements/xf_display_panel.m.js",
"file_manager/foreground/elements/xf_panel_item.m.js",
# Files app UI:
"file_manager/foreground/js/ui/a11y_announce.m.js",
......@@ -395,8 +404,11 @@ generate_grd("build_grd") {
"file_manager/background/js/main_background.m.rollup.js",
"file_manager/foreground/elements/files_icon_button.m.js",
"file_manager/foreground/elements/files_toggle_ripple.m.js",
"file_manager/foreground/elements/files_ripple.m.js",
"file_manager/foreground/elements/files_toggle_ripple.m.js",
"file_manager/foreground/js/deferred_elements.m.rollup.js",
"file_manager/foreground/js/main.m.rollup.js",
"file_manager/foreground/js/shared.m.rollup.js",
"video_player/js/main.m.rollup.js",
"video_player/js/main_background.m.rollup.js",
......@@ -408,6 +420,8 @@ generate_grd("build_grd") {
"audio_player/js/metadata_worker.m.rollup.js|audio_player/js/metadata_worker.m.js",
"image_loader/background.m.rollup.js|image_loader/background.m.js",
"file_manager/background/js/main_background.m.rollup.js|file_manager/background/js/main_background.m.js",
"file_manager/foreground/js/deferred_elements.m.rollup.js|file_manager/foreground/js/deferred_elements.m.js",
"file_manager/foreground/js/main.m.rollup.js|file_manager/foreground/js/main.m.js",
"video_player/js/main.m.rollup.js|video_player/js/main.m.js",
"video_player/js/main_background.m.rollup.js|video_player/js/main_background.m.js",
]
......@@ -425,6 +439,7 @@ generate_grd("build_grd") {
"//ui/file_manager/audio_player/js:build_worker",
"//ui/file_manager/file_manager/background/js:build",
"//ui/file_manager/file_manager/foreground/elements:elements",
"//ui/file_manager/file_manager/foreground/js:build",
"//ui/file_manager/image_loader:build",
"//ui/file_manager/video_player/js:build",
"//ui/file_manager/video_player/js:build_background",
......
ui/file_manager/file_manager/foreground/elements/BUILD.gn
View file @ d69ae10a
......@@ -13,12 +13,14 @@ visibility = [ "//ui/file_manager/file_manager/foreground/*" ]
group("elements") {
visibility += [ "//ui/file_manager/*" ]
public_deps = [
"//ui/file_manager/file_manager/foreground/elements:files_format_dialog_module",
"//ui/file_manager/file_manager/foreground/elements:files_icon_button_module",
"//ui/file_manager/file_manager/foreground/elements:files_metadata_box_module",
"//ui/file_manager/file_manager/foreground/elements:files_metadata_entry_module",
"//ui/file_manager/file_manager/foreground/elements:files_quick_view_module",
"//ui/file_manager/file_manager/foreground/elements:files_ripple_module",
"//ui/file_manager/file_manager/foreground/elements:files_safe_media_module",
"//ui/file_manager/file_manager/foreground/elements:files_spinner",
"//ui/file_manager/file_manager/foreground/elements:files_toast_module",
"//ui/file_manager/file_manager/foreground/elements:files_toggle_ripple_module",
"//ui/file_manager/file_manager/foreground/elements:files_tooltip_module",
......
ui/file_manager/file_manager/foreground/js/BUILD.gn
View file @ d69ae10a
......@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//chrome/browser/resources/tools/optimize_webui.gni")
import("//third_party/closure_compiler/compile_js.gni")
import("//third_party/closure_compiler/js_unit_tests.gni")
import("//ui/file_manager/base/gn/js_test_gen_html.gni")
......@@ -700,6 +701,7 @@ js_library("elements_importer.m") {
}
js_library("deferred_elements.m") {
visibility += [ "//ui/file_manager:*" ]
deps = [
"//ui/file_manager/file_manager/foreground/elements:files_format_dialog.m",
"//ui/file_manager/file_manager/foreground/elements:files_message.m",
......@@ -2141,3 +2143,31 @@ js_modulizer("modulize") {
"window.importElementsPromise|importElements",
]
}
preprocess_folder =
rebase_path(
"$target_gen_dir/../../../preprocessed/file_manager/foreground/js",
root_build_dir)
optimize_webui("build") {
host = "file_manager"
input = preprocess_folder
js_module_in_files = [
"main.m.js",
"deferred_elements.m.js",
]
js_out_files = [
"main.m.rollup.js",
"deferred_elements.m.rollup.js",
"shared.m.rollup.js",
]
deps = [
":main.m",
"//ui/file_manager:preprocess_generated",
"//ui/file_manager:preprocess_static",
"//ui/webui/resources:preprocess",
]
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment