desktop-pwas: DesktopPWAsCacheDuringDefaultInstall

We add a flag to allow disabling of waiting for Service Worker
to be registered during installation of default installed windows apps.

Bug: 905898
Change-Id: I9649515240ca86023b94b135973a476c046ea38c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771640
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691029}

chrome/browser/web_applications/pending_app_manager_impl.cc

@@ -11,6 +11,7 @@
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
+#include "base/feature_list.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/web_applications/components/app_registrar.h"
@@ -18,6 +19,7 @@
 #include "chrome/browser/web_applications/components/web_app_constants.h"
 #include "chrome/browser/web_applications/components/web_app_ui_manager.h"
 #include "chrome/browser/web_applications/pending_app_registration_task.h"
+#include "chrome/common/chrome_features.h"
 #include "content/public/browser/web_contents.h"
 
 namespace web_app {
@@ -254,7 +256,9 @@ void PendingAppManagerImpl::OnInstalled(PendingAppInstallTask::Result result) {
 void PendingAppManagerImpl::CurrentInstallationFinished(
     const base::Optional<AppId>& app_id,
     InstallResultCode code) {
-  if (app_id && code == InstallResultCode::kSuccessNewInstall) {
+  if (app_id && code == InstallResultCode::kSuccessNewInstall &&
+      base::FeatureList::IsEnabled(
+          features::kDesktopPWAsCacheDuringDefaultInstall)) {
     const GURL& launch_url = registrar()->GetAppLaunchURL(*app_id);
     if (!launch_url.is_empty() && launch_url.scheme() != "chrome")
       pending_registrations_.push_back(launch_url);

chrome/common/chrome_features.cc

@@ -225,6 +225,11 @@ const base::Feature kDesktopCaptureTabSharingInfobar{
 const base::Feature kDesktopPWAsWithoutExtensions{
     "DesktopPWAsWithoutExtensions", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// When installing default installed PWAs, we wait for service workers
+// to cache resources.
+const base::Feature kDesktopPWAsCacheDuringDefaultInstall{
+    "DesktopPWAsCacheDuringDefaultInstall", base::FEATURE_ENABLED_BY_DEFAULT};
+
 // Enables local PWA installs to update their app manifest data if the site
 // changes its manifest.
 const base::Feature kDesktopPWAsLocalUpdating{"DesktopPWAsLocalUpdating",

chrome/common/chrome_features.h

@@ -134,6 +134,9 @@ extern const base::Feature kDesktopCaptureTabSharingInfobar;
 COMPONENT_EXPORT(CHROME_FEATURES)
 extern const base::Feature kDesktopPWAsWithoutExtensions;
 
+COMPONENT_EXPORT(CHROME_FEATURES)
+extern const base::Feature kDesktopPWAsCacheDuringDefaultInstall;
+
 COMPONENT_EXPORT(CHROME_FEATURES)
 extern const base::Feature kDesktopPWAsLocalUpdating;