Commit d6cf4713 authored by Yusuf Sengul's avatar Yusuf Sengul Committed by Commit Bot

Fix the image size option in the content url

?sz={n} query parameter to specify the Google profile image size doesn't work. It may not be supported anymore. This change fixes it as well as adds logging in a couple of places.

Bug: 1019032
Change-Id: I4fe794ac5e8f04b3624de2d021dd2a526e565294
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885346Reviewed-by: default avatarTien Mai <tienmai@chromium.org>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#710579}
parent e23b7220
...@@ -202,7 +202,7 @@ class EscrowServiceRequest { ...@@ -202,7 +202,7 @@ class EscrowServiceRequest {
HRESULT hr = requester->fetcher_->Fetch(&requester->response_); HRESULT hr = requester->fetcher_->Fetch(&requester->response_);
if (FAILED(hr)) if (FAILED(hr))
LOGFN(INFO) << "fetcher.Fetch hr=" << putHR(hr); LOGFN(ERROR) << "fetcher.Fetch hr=" << putHR(hr);
requester->ProcessingDone(); requester->ProcessingDone();
return 0; return 0;
...@@ -710,6 +710,8 @@ HRESULT PasswordRecoveryManager::StoreWindowsPasswordIfNeeded( ...@@ -710,6 +710,8 @@ HRESULT PasswordRecoveryManager::StoreWindowsPasswordIfNeeded(
LOGFN(ERROR) << "StorePrivateData hr=" << putHR(hr); LOGFN(ERROR) << "StorePrivateData hr=" << putHR(hr);
return hr; return hr;
} }
LOGFN(INFO) << "Encrypted and stored secret for sid=" << sid;
} else { } else {
LOGFN(ERROR) << "base::JSONWriter::Write failed"; LOGFN(ERROR) << "base::JSONWriter::Write failed";
return E_FAIL; return E_FAIL;
...@@ -770,6 +772,8 @@ HRESULT PasswordRecoveryManager::RecoverWindowsPasswordIfPossible( ...@@ -770,6 +772,8 @@ HRESULT PasswordRecoveryManager::RecoverWindowsPasswordIfPossible(
*recovered_password = decrypted_password; *recovered_password = decrypted_password;
SecurelyClearString(decrypted_password); SecurelyClearString(decrypted_password);
LOGFN(INFO) << "Decrypted the secret for sid=" << sid;
return hr; return hr;
} }
......
...@@ -325,8 +325,8 @@ HRESULT UpdateProfilePicturesForWindows8AndNewer( ...@@ -325,8 +325,8 @@ HRESULT UpdateProfilePicturesForWindows8AndNewer(
continue; continue;
} }
std::string current_picture_url = base::UTF16ToUTF8(picture_url) + std::string current_picture_url =
base::StringPrintf("?sz=%i", image_size); base::UTF16ToUTF8(picture_url) + base::StringPrintf("=s%i", image_size);
auto fetcher = WinHttpUrlFetcher::Create(GURL(current_picture_url)); auto fetcher = WinHttpUrlFetcher::Create(GURL(current_picture_url));
if (!fetcher) { if (!fetcher) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment