Commit d7192b7f authored by Matt Menke's avatar Matt Menke Committed by Commit Bot

Make ash code use two argument ResponseHeader manipulation calls

We want to get rid of the single argument AddHeader() method as the two
argument AddHeader() and SetHeader() methods are safer and more flexible.

Bug: 1068194
Change-Id: I2a51b9ca2162b772f3a259e8568f7d1f98c08ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149629
Auto-Submit: Matt Menke <mmenke@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: default avatarJenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759719}
parent 33a9f610
......@@ -391,10 +391,9 @@ SearchResultAnswerCardView::CreateAnswerCardResponseHeadersForTest(
const std::string& title) {
auto headers =
base::MakeRefCounted<net::HttpResponseHeaders>("HTTP/1.1 200 OK");
headers->AddHeader(base::StrCat({kSearchAnswerHasResult, ": true"}));
headers->AddHeader(base::StrCat({kSearchAnswerTitle, ": ", title.c_str()}));
headers->AddHeader(
base::StrCat({kSearchAnswerIssuedQuery, ": ", query.c_str()}));
headers->SetHeader(kSearchAnswerHasResult, "true");
headers->SetHeader(kSearchAnswerTitle, title);
headers->SetHeader(kSearchAnswerIssuedQuery, query);
return headers;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment