[Autofill assistant] Keep generated password until end of the flow

Bug: 1110942a

Change-Id: If829d88ecc353ba86d20f1197f94365313f5e778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332608
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#795094}

components/autofill_assistant/browser/actions/save_generated_password_action.cc

@@ -12,16 +12,6 @@
 
 namespace autofill_assistant {
 
-namespace {
-
-void ClearAdditionalValue(const std::string& key,
-                          UserData* user_data,
-                          UserData::FieldChange* field_change) {
-  DCHECK(user_data);
-  user_data->additional_values_.erase(key);
-}
-}  // namespace
-
 SaveGeneratedPasswordAction::SaveGeneratedPasswordAction(
     ActionDelegate* delegate,
     const ActionProto& proto)
@@ -65,9 +55,6 @@ void SaveGeneratedPasswordAction::InternalProcessAction(
 
   delegate_->GetWebsiteLoginManager()->CommitGeneratedPassword();
 
-  delegate_->WriteUserData(
-      base::BindOnce(&ClearAdditionalValue, save_password.memory_key()));
-
   EndAction(ClientStatus(ACTION_APPLIED));
 }
 

components/autofill_assistant/browser/actions/save_generated_password_action_unittest.cc

@@ -72,7 +72,7 @@ TEST_F(SaveGeneratedPasswordActionTest, SavedPassword) {
 
   action.ProcessAction(callback_.Get());
 
-  EXPECT_FALSE(user_data_.has_additional_value(kMemoryKeyForGeneratedPassword));
+  EXPECT_TRUE(user_data_.has_additional_value(kMemoryKeyForGeneratedPassword));
 }
 
 TEST_F(SaveGeneratedPasswordActionTest, MissingMemoryKeyPreconditionFails) {