Commit d7c99553 authored by Mihai Sardarescu's avatar Mihai Sardarescu Committed by Commit Bot

Remove TODO in PushClientChannel::UpdateCredentials.

Bug: 1028523
Change-Id: I7c1de5e352bbf696e9d0a59c72d616c8daeafd8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942434
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720021}
parent f835a8e6
...@@ -77,8 +77,12 @@ void PushClientChannel::UpdateCredentials(const CoreAccountId& account_id, ...@@ -77,8 +77,12 @@ void PushClientChannel::UpdateCredentials(const CoreAccountId& account_id,
} }
} }
)"); )");
// TODO(https://crbug.com/1010544): Possibly pass an account id instead of
// string here. // PushClient::UpdateCredentials() expects an email as the first argument.
// The current code below is passing the account_id which is created from
// a Gaia ID or an email.
// TODO(crbug.com/939039): Remove this code once the migration tracked in
// this bug is complete.
push_client_->UpdateCredentials(account_id.ToString(), token, push_client_->UpdateCredentials(account_id.ToString(), token,
traffic_annotation); traffic_annotation);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment