Skip to content

GitLab

T
tangled
Commit d7db3e1f authored by Aaron Leventhal's avatar Aaron Leventhal Committed by Commit Bot
Browse files
Options

New ARIA insertion and deletion roles 

Bug: 945366
Change-Id: I35fa5fb658ebbfdf478ad2a59aaffdf44bb7a802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538015Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644808}
parent ac22a3f5
Hide whitespace changes
Inline Side-by-side
Showing with 72 additions and 0 deletions
content/browser/accessibility/dump_accessibility_tree_browsertest.cc
View file @ d7db3e1f
...@@ -548,6 +548,11 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaImg) { ...@@ -548,6 +548,11 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaImg) {
RunAriaTest(FILE_PATH_LITERAL("aria-img.html")); RunAriaTest(FILE_PATH_LITERAL("aria-img.html"));
} }
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
AccessibilityAriaInsertionDeletion) {
RunAriaTest(FILE_PATH_LITERAL("aria-insertion-deletion.html"));
}
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaInvalid) { IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaInvalid) {
RunAriaTest(FILE_PATH_LITERAL("aria-invalid.html")); RunAriaTest(FILE_PATH_LITERAL("aria-invalid.html"));
} }
......
content/test/data/accessibility/aria/aria-insertion-deletion-expected-android.txt 0 → 100644
View file @ d7db3e1f
android.webkit.WebView focusable focused scrollable
++android.view.View
++++android.view.View name='My favorite browser is '
++++android.view.View role_description='deletion' name='ABC'
++++android.view.View name=' '
++++android.view.View role_description='insertion' name='Chrome'
++++android.view.View name='!'
content/test/data/accessibility/aria/aria-insertion-deletion-expected-auralinux.txt 0 → 100644
View file @ d7db3e1f
[document web]
++[paragraph]
++++[text] name='My favorite browser is '
++++[section]
++++++[text] name='ABC'
++++[text] name=' '
++++[section]
++++++[text] name='Chrome'
++++[text] name='!'
content/test/data/accessibility/aria/aria-insertion-deletion-expected-blink.txt 0 → 100644
View file @ d7db3e1f
rootWebArea
++paragraph
++++staticText name='My favorite browser is '
++++++inlineTextBox name='My favorite browser is '
++++contentDeletion
++++++staticText name='ABC'
++++++++inlineTextBox name='ABC'
++++staticText name=' '
++++++inlineTextBox name=' '
++++contentInsertion
++++++staticText name='Chrome'
++++++++inlineTextBox name='Chrome'
++++staticText name='!'
++++++inlineTextBox name='!'
content/test/data/accessibility/aria/aria-insertion-deletion-expected-mac.txt 0 → 100644
View file @ d7db3e1f
AXWebArea
++AXGroup
++++AXStaticText AXValue='My favorite browser is '
++++AXGroup AXSubrole=AXDeleteStyleGroup
++++++AXStaticText AXValue='ABC'
++++AXStaticText AXValue=' '
++++AXGroup AXSubrole=AXInsertStyleGroup
++++++AXStaticText AXValue='Chrome'
++++AXStaticText AXValue='!'
content/test/data/accessibility/aria/aria-insertion-deletion-expected-win.txt 0 → 100644
View file @ d7db3e1f
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
++IA2_ROLE_PARAGRAPH
++++ROLE_SYSTEM_STATICTEXT name='My favorite browser is '
++++IA2_ROLE_CONTENT_DELETION
++++++ROLE_SYSTEM_STATICTEXT name='ABC'
++++ROLE_SYSTEM_STATICTEXT name=' '
++++IA2_ROLE_CONTENT_INSERTION
++++++ROLE_SYSTEM_STATICTEXT name='Chrome'
++++ROLE_SYSTEM_STATICTEXT name='!'
content/test/data/accessibility/aria/aria-insertion-deletion.html 0 → 100644
View file @ d7db3e1f
<!--
@MAC-ALLOW:AXSubrole=*
-->
<!DOCTYPE html>
<html>
<head>
<style>
/* Make the text small so that it doesn't line-wrap. */
p { font-size: 8px; }
</style>
</head>
<body>
<p>My favorite browser is <span role="deletion">ABC</span> <span role="insertion">Chrome</span>!</p>
</body>
</html>
third_party/blink/renderer/modules/accessibility/ax_object.cc
View file @ d7db3e1f
...@@ -105,6 +105,7 @@ const RoleEntry kRoles[] = { ...@@ -105,6 +105,7 @@ const RoleEntry kRoles[] = {
{"complementary", ax::mojom::Role::kComplementary}, {"complementary", ax::mojom::Role::kComplementary},
{"contentinfo", ax::mojom::Role::kContentInfo}, {"contentinfo", ax::mojom::Role::kContentInfo},
{"definition", ax::mojom::Role::kDefinition}, {"definition", ax::mojom::Role::kDefinition},
{"deletion", ax::mojom::Role::kContentDeletion},
{"dialog", ax::mojom::Role::kDialog}, {"dialog", ax::mojom::Role::kDialog},
{"directory", ax::mojom::Role::kDirectory}, {"directory", ax::mojom::Role::kDirectory},
// ------------------------------------------------- // -------------------------------------------------
...@@ -168,6 +169,7 @@ const RoleEntry kRoles[] = { ...@@ -168,6 +169,7 @@ const RoleEntry kRoles[] = {
{"group", ax::mojom::Role::kGroup}, {"group", ax::mojom::Role::kGroup},
{"heading", ax::mojom::Role::kHeading}, {"heading", ax::mojom::Role::kHeading},
{"img", ax::mojom::Role::kImage}, {"img", ax::mojom::Role::kImage},
{"insertion", ax::mojom::Role::kContentInsertion},
{"link", ax::mojom::Role::kLink}, {"link", ax::mojom::Role::kLink},
{"list", ax::mojom::Role::kList}, {"list", ax::mojom::Role::kList},
{"listbox", ax::mojom::Role::kListBox}, {"listbox", ax::mojom::Role::kListBox},
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment