Commit d7df01a3 authored by Fergal Daly's avatar Fergal Daly Committed by Chromium LUCI CQ

Add DumpWithoutCrashing to track down an Android-only crash.


Bug: 1163509
Change-Id: I5f8df01e1a81c65b1a959258b6f95740981d4913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612657
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840940}
parent 514a77b5
......@@ -2801,6 +2801,41 @@ bool RenderFrameHostManager::InitRenderFrame(
int previous_routing_id =
GetReplacementRoutingId(existing_proxy, render_frame_host);
// TOOD(https://crbug.com/1163509): Delete this.
if (previous_routing_id == MSG_ROUTING_NONE &&
parent_routing_id == MSG_ROUTING_NONE) {
// If this was true we would have CHECK-failed above.
SCOPED_CRASH_KEY_BOOL("bug-1163509", "has_parent",
!!frame_tree_node_->parent());
// If this was true we would have CHECK-failed in GetReplacementRoutingId.
SCOPED_CRASH_KEY_BOOL("bug-1163509", "existing_proxy", !!existing_proxy);
// This must be true since existing_proxy is false and previous_routing_id
// is NONE.
SCOPED_CRASH_KEY_BOOL("bug-1163509", "SameSiteInstance",
render_frame_host->GetSiteInstance() ==
current_frame_host()->GetSiteInstance());
SCOPED_CRASH_KEY_STRING64("bug-1163509", "old->SiteInstance",
current_frame_host()
->GetSiteInstance()
->GetSiteURL()
.possibly_invalid_spec());
SCOPED_CRASH_KEY_STRING64("bug-1163509", "new->SiteInstance",
render_frame_host->GetSiteInstance()
->GetSiteURL()
.possibly_invalid_spec());
SCOPED_CRASH_KEY_BOOL("bug-1163509", "IsRenderFrameLive",
current_frame_host()->IsRenderFrameLive());
// If the frame is live then the previous_routing_id comes from the current
// RFH.
SCOPED_CRASH_KEY_NUMBER("bug-1163509", "old->GetRoutingID",
current_frame_host()->GetRoutingID());
SCOPED_CRASH_KEY_NUMBER("bug-1163509", "new->GetRoutingID",
render_frame_host->GetRoutingID());
SCOPED_CRASH_KEY_BOOL("bug-1163509", "must_be_replaced",
current_frame_host()->must_be_replaced());
NOTREACHED();
base::debug::DumpWithoutCrashing();
}
return render_frame_host->CreateRenderFrame(
previous_routing_id, opener_frame_token, parent_routing_id,
previous_sibling_routing_id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment