Commit d7e12590 authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

Android: Fix stack script when run not from src/ directory

Noticed my test stack wasn't symbolizing when I ran the script with
PWD=$SRC/out/Debug

Turns out the stack script calls os.chdir() at some point, so need to
save --output-directory as an absolute path.

Also updated other paths passed as flags to use abspath().

Change-Id: I91fe857fa1af5c94b2783b0f4083f4d4ef927e68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776611
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarChristopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692028}
parent fb3afdd4
......@@ -167,9 +167,9 @@ def main(argv):
if option == "--help":
PrintUsage()
elif option == "--symbols-dir":
symbol.SYMBOLS_DIR = os.path.expanduser(value)
symbol.SYMBOLS_DIR = os.path.abspath(os.path.expanduser(value))
elif option == "--symbols-zip":
zip_arg = os.path.expanduser(value)
zip_arg = os.path.abspath(os.path.expanduser(value))
elif option == "--arch":
symbol.ARCH = value
arch_defined = True
......@@ -177,9 +177,9 @@ def main(argv):
symbol.CHROME_SYMBOLS_DIR = os.path.join(constants.DIR_SOURCE_ROOT,
value)
elif option == "--output-directory":
constants.SetOutputDirectory(value)
constants.SetOutputDirectory(os.path.abspath(value))
elif option == "--packed-lib":
packed_libs.append(os.path.expanduser(value))
packed_libs.append(os.path.abspath(os.path.expanduser(value)))
elif option == "--more-info":
more_info = True
elif option == "--less-info":
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment