Commit d803647a authored by Koji Ishii's avatar Koji Ishii Committed by Commit Bot

[FragmentItem] Add PostLayout guard to AddOutlineRectsForNormalChildren

This patch adds |PostLayout| gurad to FragmentItem codepath
in |AddOutlineRectsForNormalChildren|.

While I have not succeeded to reproduce the issue locally,
this is the most likely the reason from the stack traces.

This patch is speculative.

Bug: 1105283
Change-Id: I94813dc011e6a43a08a111ad7dfc51804d7877de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303417Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789853}
parent ad1651a8
......@@ -112,6 +112,8 @@ void NGPhysicalContainerFragment::AddOutlineRectsForNormalChildren(
}
if (item.Type() == NGFragmentItem::kBox) {
if (const NGPhysicalBoxFragment* child_box = item.BoxFragment()) {
if (const NGPhysicalFragment* post_layout = child_box->PostLayout())
child_box = To<NGPhysicalBoxFragment>(post_layout);
DCHECK(!child_box->IsOutOfFlowPositioned());
AddOutlineRectsForDescendant(
{child_box, item.OffsetInContainerBlock()}, outline_rects,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment