Commit d80961f5 authored by Ana Salazar's avatar Ana Salazar Committed by Commit Bot

Cros: Scale folder dropping circle to icon scale

When the apps grid enters cardified state, all icons are scaled down
84%. We need to scale down the folder circle proportionally, to avoid
clipping at the top edges.

Bug: 1108644
Change-Id: I95b97d6d3db15c0313a92bbffbd5f70ffb4e071e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315094Reviewed-by: default avatarToni Baržić <tbarzic@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791998}
parent abb08a37
...@@ -886,7 +886,7 @@ void AppListItemView::AnimationProgressed(const gfx::Animation* animation) { ...@@ -886,7 +886,7 @@ void AppListItemView::AnimationProgressed(const gfx::Animation* animation) {
preview_circle_radius_ = gfx::Tween::IntValueBetween( preview_circle_radius_ = gfx::Tween::IntValueBetween(
animation->GetCurrentValue(), 0, animation->GetCurrentValue(), 0,
GetAppListConfig().folder_dropping_circle_radius()); GetAppListConfig().folder_dropping_circle_radius() * icon_scale_);
SchedulePaint(); SchedulePaint();
} }
......
...@@ -1706,7 +1706,8 @@ bool AppsGridView::DragPointIsOverItem(const gfx::Point& point) { ...@@ -1706,7 +1706,8 @@ bool AppsGridView::DragPointIsOverItem(const gfx::Point& point) {
(point - GetExpectedTileBounds(nearest_tile_index).CenterPoint()) (point - GetExpectedTileBounds(nearest_tile_index).CenterPoint())
.Length(); .Length();
if (distance_to_tile_center > if (distance_to_tile_center >
GetAppListConfig().folder_dropping_circle_radius()) { (GetAppListConfig().folder_dropping_circle_radius() *
(cardified_state_ ? kCardifiedScale : 1.0f))) {
return false; return false;
} }
...@@ -1744,7 +1745,8 @@ void AppsGridView::UpdateDropTargetForReorder(const gfx::Point& point) { ...@@ -1744,7 +1745,8 @@ void AppsGridView::UpdateDropTargetForReorder(const gfx::Point& point) {
// between apps. // between apps.
int x_offset = int x_offset =
x_offset_direction * (total_tile_size.width() / 2 - x_offset_direction * (total_tile_size.width() / 2 -
GetAppListConfig().folder_dropping_circle_radius()); GetAppListConfig().folder_dropping_circle_radius() *
(cardified_state_ ? kCardifiedScale : 1.0f));
int col = (point.x() - bounds.x() + x_offset) / total_tile_size.width(); int col = (point.x() - bounds.x() + x_offset) / total_tile_size.width();
col = base::ClampToRange(col, 0, cols_ - 1); col = base::ClampToRange(col, 0, cols_ - 1);
drop_target_ = drop_target_ =
...@@ -1781,7 +1783,8 @@ bool AppsGridView::DragIsCloseToItem() { ...@@ -1781,7 +1783,8 @@ bool AppsGridView::DragIsCloseToItem() {
(GetAppListConfig().grid_tile_width() + horizontal_tile_padding_ * 2) * (GetAppListConfig().grid_tile_width() + horizontal_tile_padding_ * 2) *
0.4; 0.4;
const int double_icon_radius = const int double_icon_radius =
GetAppListConfig().folder_dropping_circle_radius() * 2; GetAppListConfig().folder_dropping_circle_radius() * 2 *
(cardified_state_ ? kCardifiedScale : 1.0f);
const int minimum_drag_distance_for_reorder = const int minimum_drag_distance_for_reorder =
std::min(forty_percent_icon_spacing, double_icon_radius); std::min(forty_percent_icon_spacing, double_icon_radius);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment