Commit d816efbf authored by Raphael Kubo da Costa's avatar Raphael Kubo da Costa Committed by Commit Bot

wake lock: Use content::EvalJs() in browser tests

Replace uses of content::ExecuteScriptAndExtractString() and variations with
content::EvalJs(). The code looks smaller, simpler and easier to understand.

Change-Id: I1ebac4f1084176d490487d548eec931021df5f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855979
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705146}
parent 92c30030
...@@ -154,13 +154,9 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest, RequestPermissionScreen) { ...@@ -154,13 +154,9 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest, RequestPermissionScreen) {
PermissionRequestObserver observer( PermissionRequestObserver observer(
browser()->tab_strip_model()->GetActiveWebContents()); browser()->tab_strip_model()->GetActiveWebContents());
std::string response; EXPECT_EQ("granted", content::EvalJs(
EXPECT_TRUE(content::ExecuteScriptAndExtractString( browser()->tab_strip_model()->GetActiveWebContents(),
browser()->tab_strip_model()->GetActiveWebContents(), "WakeLock.requestPermission('screen')"));
"WakeLock.requestPermission('screen').then(status => "
" domAutomationController.send(status));",
&response));
EXPECT_EQ(response, "granted");
EXPECT_EQ(observer.request_shown(), false); EXPECT_EQ(observer.request_shown(), false);
} }
...@@ -172,13 +168,11 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest, ...@@ -172,13 +168,11 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest,
PermissionRequestObserver observer( PermissionRequestObserver observer(
browser()->tab_strip_model()->GetActiveWebContents()); browser()->tab_strip_model()->GetActiveWebContents());
std::string response; EXPECT_EQ(
EXPECT_TRUE(content::ExecuteScriptWithoutUserGestureAndExtractString( "granted",
browser()->tab_strip_model()->GetActiveWebContents(), content::EvalJs(browser()->tab_strip_model()->GetActiveWebContents(),
"WakeLock.requestPermission('screen').then(status => " "WakeLock.requestPermission('screen')",
" domAutomationController.send(status));", content::EvalJsOptions::EXECUTE_SCRIPT_NO_USER_GESTURE));
&response));
EXPECT_EQ(response, "granted");
EXPECT_EQ(observer.request_shown(), false); EXPECT_EQ(observer.request_shown(), false);
} }
...@@ -189,13 +183,9 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest, RequestPermissionSystem) { ...@@ -189,13 +183,9 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest, RequestPermissionSystem) {
PermissionRequestObserver observer( PermissionRequestObserver observer(
browser()->tab_strip_model()->GetActiveWebContents()); browser()->tab_strip_model()->GetActiveWebContents());
std::string response; EXPECT_EQ("denied", content::EvalJs(
EXPECT_TRUE(content::ExecuteScriptAndExtractString( browser()->tab_strip_model()->GetActiveWebContents(),
browser()->tab_strip_model()->GetActiveWebContents(), "WakeLock.requestPermission('system')"));
"WakeLock.requestPermission('system').then(status => "
" domAutomationController.send(status));",
&response));
EXPECT_EQ(response, "denied");
EXPECT_EQ(observer.request_shown(), false); EXPECT_EQ(observer.request_shown(), false);
} }
...@@ -207,12 +197,10 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest, ...@@ -207,12 +197,10 @@ IN_PROC_BROWSER_TEST_F(WakeLockBrowserTest,
PermissionRequestObserver observer( PermissionRequestObserver observer(
browser()->tab_strip_model()->GetActiveWebContents()); browser()->tab_strip_model()->GetActiveWebContents());
std::string response; EXPECT_EQ(
EXPECT_TRUE(content::ExecuteScriptWithoutUserGestureAndExtractString( "denied",
browser()->tab_strip_model()->GetActiveWebContents(), content::EvalJs(browser()->tab_strip_model()->GetActiveWebContents(),
"WakeLock.requestPermission('system').then(status => " "WakeLock.requestPermission('system')",
" domAutomationController.send(status));", content::EvalJsOptions::EXECUTE_SCRIPT_NO_USER_GESTURE));
&response));
EXPECT_EQ(response, "denied");
EXPECT_EQ(observer.request_shown(), false); EXPECT_EQ(observer.request_shown(), false);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment