Add a comment at the top of export_template.h explaining the goal of all the template magic.
These macros are used in all of 3 files. Instead of all this magic, maybe the components that need this should define FOO_TEMPLATE_EXPORT_DECLARE and FOO_TEMPLATE_EXPORT_DEFINE in their foo_export.h file instead, and make it expand to the right thing there. That seems a lot simpler and easier to understand. But for now, let's just add a comment. Bug: none Change-Id: I5fd56440a07a4c7ba879af6d809c7e1397d05737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890531 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710908}
Showing
Please register or sign in to comment