Commit d826b257 authored by rbpotter's avatar rbpotter Committed by Commit Bot

Extensions Web UI: Only build optimized page when optimize_webui=true

There is no reason to build the :build, :flattened_resources, or :unpak
targets when optimize_webui=false.

Bug: 1004967
Change-Id: Ib7e2cf5896279ccb984701987519d9e311944d40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829753
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701233}
parent 5739f4df
......@@ -7,46 +7,48 @@ import("//third_party/closure_compiler/compile_js.gni")
import("//tools/grit/grit_rule.gni")
import("../optimize_webui.gni")
extensions_pak_file = "extensions_resources.pak"
unpak_folder = "extensions_resources.unpak"
optimize_webui("build") {
host = "extensions"
html_in_files = [ "extensions.html" ]
html_out_files = [ "vulcanized.html" ]
insert_in_head = "<base href=\"chrome://extensions\">"
input = rebase_path("$target_gen_dir/$unpak_folder", root_build_dir)
js_out_files = [ "crisper.js" ]
replace_for_html_imports_polyfill = "crisper.js"
deps = [
":unpak",
]
}
unpak("unpak") {
pak_file = extensions_pak_file
out_folder = unpak_folder
deps = [
":flattened_resources",
]
}
grit("flattened_resources") {
source = "extensions_resources.grd"
# The .grd contains references to generated files.
source_is_generated = true
defines = chrome_grit_defines
outputs = [
"grit/extensions_resources.h",
"grit/extensions_resources_map.cc",
"grit/extensions_resources_map.h",
extensions_pak_file,
]
output_dir = "$root_gen_dir/chrome/browser/resources/extensions"
if (optimize_webui) {
extensions_pak_file = "extensions_resources.pak"
unpak_folder = "extensions_resources.unpak"
optimize_webui("build") {
host = "extensions"
html_in_files = [ "extensions.html" ]
html_out_files = [ "vulcanized.html" ]
insert_in_head = "<base href=\"chrome://extensions\">"
input = rebase_path("$target_gen_dir/$unpak_folder", root_build_dir)
js_out_files = [ "crisper.js" ]
replace_for_html_imports_polyfill = "crisper.js"
deps = [
":unpak",
]
}
unpak("unpak") {
pak_file = extensions_pak_file
out_folder = unpak_folder
deps = [
":flattened_resources",
]
}
grit("flattened_resources") {
source = "extensions_resources.grd"
# The .grd contains references to generated files.
source_is_generated = true
defines = chrome_grit_defines
outputs = [
"grit/extensions_resources.h",
"grit/extensions_resources_map.cc",
"grit/extensions_resources_map.h",
extensions_pak_file,
]
output_dir = "$root_gen_dir/chrome/browser/resources/extensions"
}
}
group("closure_compile") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment