[ios] Makes SettingsRootTableVC conform to AdaptivePresentationControllerDelegate

Since Settings might embed 3rd party ViewControllers, the only interface we could
expect from them in order to clean up or rubberband when swiping down to dismiss
are the AdaptivePresentationControllerDelegate instance methods. For this reason
SettingsRootTableVC now conforms to AdaptivePresentationControllerDelegate, and
any subclass can override or implement any of the these methods.

This CL also forwards all AdaptivePresentationControllerDelegate method calls into
the currently presented Settings VC.

Bug: 1006304
Change-Id: I0ff47d755e5c3e67029e210dfb94d21d700520cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832104Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702016}

ios/chrome/browser/ui/settings/autofill/autofill_credit_card_edit_table_view_controller.mm

@@ -303,9 +303,10 @@ typedef NS_ENUM(NSInteger, ItemType) {
   }
 }
 
-#pragma mark - SettingsRootTableViewController
+#pragma mark - UIAdaptivePresentationControllerDelegate
 
-- (BOOL)shouldDismissViewControllerBySwipeDown {
+- (BOOL)presentationControllerShouldDismiss:
+    (UIPresentationController*)presentationController {
   return !self.tableView.editing;
 }
 

ios/chrome/browser/ui/settings/autofill/autofill_edit_table_view_controller.mm

@@ -73,7 +73,10 @@
   return YES;
 }
 
-- (BOOL)shouldDismissViewControllerBySwipeDown {
+#pragma mark - UIAdaptivePresentationControllerDelegate
+
+- (BOOL)presentationControllerShouldDismiss:
+    (UIPresentationController*)presentationController {
   return !self.tableView.editing;
 }
 

ios/chrome/browser/ui/settings/clear_browsing_data/clear_browsing_data_table_view_controller.mm

@@ -334,12 +334,6 @@
   }
 }
 
-#pragma mark - SettingsRootTableViewController
-
-- (BOOL)shouldDismissViewControllerBySwipeDown {
-  return !self.chromeActivityOverlayCoordinator.started;
-}
-
 #pragma mark - TableViewTextLinkCellDelegate
 
 - (void)tableViewTextLinkCell:(TableViewTextLinkCell*)cell
@@ -436,8 +430,8 @@
 
 - (void)presentationControllerDidDismiss:
     (UIPresentationController*)presentationController {
-  // Call dismiss to clean up state and  stop the Coordinator.
-  [self dismiss];
+  // Call prepareForDismissal to clean up state and  stop the Coordinator.
+  [self prepareForDismissal];
 }
 
 - (BOOL)presentationControllerShouldDismiss:

ios/chrome/browser/ui/settings/settings_navigation_controller.mm

@@ -47,11 +47,13 @@ NSString* const kSettingsDoneButtonId = @"kSettingsDoneButtonId";
 @property(nonatomic, strong)
     GoogleServicesSettingsCoordinator* googleServicesSettingsCoordinator;
 
-// Current SettingsViewController being presented by this Navigation Controller.
+// Current UIViewController being presented by this Navigation Controller.
 // If nil it means the Navigation Controller is not presenting anything, or the
-// VC being presented is not a SettingsRootTableViewController.
+// VC being presented doesn't conform to
+// UIAdaptivePresentationControllerDelegate.
 @property(nonatomic, weak)
-    SettingsRootTableViewController* currentPresentedSettingsViewController;
+    UIViewController<UIAdaptivePresentationControllerDelegate>*
+        currentPresentedViewController;
 
 // The SettingsNavigationControllerDelegate for this NavigationController.
 @property(nonatomic, weak) id<SettingsNavigationControllerDelegate>
@@ -376,16 +378,53 @@ initWithRootViewController:(UIViewController*)rootViewController
 
 - (BOOL)presentationControllerShouldDismiss:
     (UIPresentationController*)presentationController {
-  return [self.currentPresentedSettingsViewController
-              shouldDismissViewControllerBySwipeDown];
+  if (@available(iOS 13, *)) {
+    if ([self.currentPresentedViewController
+            respondsToSelector:@selector
+            (presentationControllerShouldDismiss:)]) {
+      return [self.currentPresentedViewController
+          presentationControllerShouldDismiss:presentationController];
+    }
+  }
+  return NO;
 }
 
 - (void)presentationControllerDidDismiss:
     (UIPresentationController*)presentationController {
+  if (@available(iOS 13, *)) {
+    if ([self.currentPresentedViewController
+            respondsToSelector:@selector(presentationControllerDidDismiss:)]) {
+      [self.currentPresentedViewController
+          presentationControllerDidDismiss:presentationController];
+    }
+  }
   // Call settingsWasDismissed to make sure any necessary cleanup is performed.
   [self.settingsNavigationDelegate settingsWasDismissed];
 }
 
+- (void)presentationControllerDidAttemptToDismiss:
+    (UIPresentationController*)presentationController {
+  if (@available(iOS 13, *)) {
+    if ([self.currentPresentedViewController
+            respondsToSelector:@selector
+            (presentationControllerDidAttemptToDismiss:)]) {
+      [self.currentPresentedViewController
+          presentationControllerDidAttemptToDismiss:presentationController];
+    }
+  }
+}
+
+- (void)presentationControllerWillDismiss:
+    (UIPresentationController*)presentationController {
+  if (@available(iOS 13, *)) {
+    if ([self.currentPresentedViewController
+            respondsToSelector:@selector(presentationControllerWillDismiss:)]) {
+      [self.currentPresentedViewController
+          presentationControllerWillDismiss:presentationController];
+    }
+  }
+}
+
 #pragma mark - Accessibility
 
 - (BOOL)accessibilityPerformEscape {
@@ -407,8 +446,9 @@ initWithRootViewController:(UIViewController*)rootViewController
 - (void)navigationController:(UINavigationController*)navigationController
       willShowViewController:(UIViewController*)viewController
                     animated:(BOOL)animated {
-  self.currentPresentedSettingsViewController =
-      base::mac::ObjCCast<SettingsRootTableViewController>(viewController);
+  self.currentPresentedViewController = base::mac::ObjCCast<
+      UIViewController<UIAdaptivePresentationControllerDelegate>>(
+      viewController);
 }
 
 #pragma mark - UIResponder

ios/chrome/browser/ui/settings/settings_root_table_view_controller.h

@@ -19,7 +19,8 @@ extern NSString* const kSettingsToolbarDeleteButtonId;
 // AppBar.
 @interface SettingsRootTableViewController
     : ChromeTableViewController <SettingsRootViewControlling,
-                                 TableViewLinkHeaderFooterItemDelegate>
+                                 TableViewLinkHeaderFooterItemDelegate,
+                                 UIAdaptivePresentationControllerDelegate>
 
 // Delete button for the toolbar.
 @property(nonatomic, strong, readonly) UIBarButtonItem* deleteButton;
@@ -81,11 +82,6 @@ extern NSString* const kSettingsToolbarDeleteButtonId;
 // * Removes the transparent veil.
 - (void)allowUserInteraction;
 
-// Returns YES. Subclasses can override to prevent a swipe down dismissal. This
-// is useful when the ViewController contains editable fields and accidental
-// dismissals want to be avoided.
-- (BOOL)shouldDismissViewControllerBySwipeDown;
-
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_SETTINGS_SETTINGS_ROOT_TABLE_VIEW_CONTROLLER_H_

ios/chrome/browser/ui/settings/settings_root_table_view_controller.mm

@@ -353,7 +353,10 @@ NSString* const kSettingsToolbarDeleteButtonId =
   self.savedBarButtonItemPosition = kUndefinedBarButtonItemPosition;
 }
 
-- (BOOL)shouldDismissViewControllerBySwipeDown {
+#pragma mark - UIAdaptivePresentationControllerDelegate
+
+- (BOOL)presentationControllerShouldDismiss:
+    (UIPresentationController*)presentationController {
   return YES;
 }
 

ios/chrome/browser/ui/settings/sync/sync_encryption_passphrase_table_view_controller.mm

@@ -189,7 +189,10 @@ const CGFloat kSpinnerButtonPadding = 18;
       forSectionWithIdentifier:SectionIdentifierPassphrase];
 }
 
-- (BOOL)shouldDismissViewControllerBySwipeDown {
+#pragma mark - UIAdaptivePresentationControllerDelegate
+
+- (BOOL)presentationControllerShouldDismiss:
+    (UIPresentationController*)presentationController {
   return ![passphrase_.text length];
 }